-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
newrule(target_spacing_sufficient
): WCAG 2.2: 2.5.8 Target size (minimum)
#1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync dev branches
philljenkins
changed the title
newrule('target_spacing_sufficient'): WCAG 2.2 minimum target size
newrule(target_spacing_sufficient): WCAG 2.2: 2.5.8 Target size (minimum)
Oct 19, 2023
This was
linked to
issues
Oct 19, 2023
New help file
removing ":", an adding comment between bullet and table
7 tasks
include the title as well as the technique SCR20:
7 tasks
tombrunet
requested changes
Nov 6, 2023
accessibility-checker-engine/src/v4/rules/element_tabbable_unobscured.ts
Outdated
Show resolved
Hide resolved
accessibility-checker-engine/help-v4/en-US/target_spacing_sufficient.html
Outdated
Show resolved
Hide resolved
accessibility-checker-engine/help-v4/en-US/target_spacing_sufficient.html
Outdated
Show resolved
Hide resolved
accessibility-checker-engine/help-v4/en-US/target_spacing_sufficient.html
Outdated
Show resolved
Hide resolved
accessibility-checker-engine/src/v2/checker/accessibility/util/legacy.ts
Outdated
Show resolved
Hide resolved
accessibility-checker-engine/src/v2/checker/accessibility/util/legacy.ts
Outdated
Show resolved
Hide resolved
accessibility-checker-engine/src/v4/rules/target_spacing_sufficient.ts
Outdated
Show resolved
Hide resolved
accessibility-checker-engine/src/v4/rules/target_spacing_sufficient.ts
Outdated
Show resolved
Hide resolved
accessibility-checker-engine/src/v4/rules/target_spacing_sufficient.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Brunet <[email protected]>
Co-authored-by: Tom Brunet <[email protected]>
Co-authored-by: Tom Brunet <[email protected]>
Co-authored-by: Tom Brunet <[email protected]>
philljenkins
reviewed
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good editorial changes
philljenkins
changed the title
newrule(target_spacing_sufficient): WCAG 2.2: 2.5.8 Target size (minimum)
newrule(Nov 8, 2023
target_spacing_sufficient
): WCAG 2.2: 2.5.8 Target size (minimum)
Co-authored-by: Tom Brunet <[email protected]>
tombrunet
reviewed
Nov 8, 2023
accessibility-checker-engine/help-v4/en-US/target_spacing_sufficient.html
Outdated
Show resolved
Hide resolved
tombrunet
previously approved these changes
Nov 8, 2023
tombrunet
previously approved these changes
Nov 8, 2023
@shunguoy we have a few conflicts, please review. |
ErickRenteria
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the following issue(s):
Additional information can be found here:
Testing reference:
...test/v2/checker/accessibility/rules/target_spacing_sufficient_ruleunit/element_target.html
Note: due to a mapping issue (#1731), the 'Violation' is showing up as "Recommendation' now. "Undersized target "{0}" does not have sufficient spacing of 12 CSS pixels from another target "{1}"",
I have conducted the following for this PR: