Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule Help]: deprecated elements, attributes, and aria-attributes #678

Closed
2 tasks done
shunguoy opened this issue Feb 9, 2022 · 12 comments
Closed
2 tasks done

[Rule Help]: deprecated elements, attributes, and aria-attributes #678

shunguoy opened this issue Feb 9, 2022 · 12 comments
Assignees
Labels
engine Issues in the accessibility-checker-engine component SME Discuss with subject matter experts

Comments

@shunguoy
Copy link
Contributor

shunguoy commented Feb 9, 2022

Project

a11y checker engine

Browser

Chrome

Operating system

MacOS

Description

This is to enhance the RPT_Elem_Deprecated rule:

  • need a help file
  • rule messages need to be more specific

Steps to reproduce

test in the extension

@aliunwala aliunwala changed the title [help]: deprecated elements, attributes, and aria-attributes [Rule Help]: deprecated elements, attributes, and aria-attributes Feb 9, 2022
@shunguoy shunguoy added the SME Discuss with subject matter experts label Feb 10, 2022
@marcjohlic marcjohlic added the engine Issues in the accessibility-checker-engine component label Feb 10, 2022
@mbgower mbgower self-assigned this Feb 17, 2022
@shunguoy
Copy link
Contributor Author

shunguoy commented Feb 18, 2022

see box note https://ibm.ent.box.com/notes/919138089437. Please first review and finalize the messages.

shunguoy added a commit that referenced this issue Feb 21, 2022
@shunguoy
Copy link
Contributor Author

@mbgower in case you need, the dev branch is https://github.com/IBMa/equal-access/tree/dev-608

@mbgower
Copy link
Contributor

mbgower commented Feb 24, 2022

I will be starting on this today

@mbgower
Copy link
Contributor

mbgower commented Feb 25, 2022

@shunguo, do you create an array of attributes that are deprecated and report them all in the event of a failure, or as you only listing the attribute used? I would assume the latter, so I have made the failure messages all singular.
image.png

@mbgower
Copy link
Contributor

mbgower commented Feb 25, 2022

@shunguoy I do not see any existing mdx help file for either RPT_Elem_Deprecated OR element_attribute_deprecated. The box note says it is an existing rule, so I assume the mdx file exists but has a different name?
I'm not seeing your tests, which would allow me to trigger the rule and find the help messages and search for the string, so maybe you could advise?

@mbgower
Copy link
Contributor

mbgower commented Feb 25, 2022

I have made some commits in a new branch off yours https://github.com/IBMa/equal-access/tree/rpt_element_attribute_deprecated_help

@mbgower
Copy link
Contributor

mbgower commented Feb 25, 2022

@philljenkins do you have any backstory on this?

@shunguoy
Copy link
Contributor Author

shunguoy commented Feb 28, 2022

@mbgower this rule doesn't have a help currently. Although it's an existing rule, it's currently not triggered.

@shunguoy
Copy link
Contributor Author

@mbgower the message file is in the accessibility-checker-engine/src/v2/checker/accessibility/nls/index.ts. You can either make the message change directly, or you can send me the messages for me to make the change.

@shunguoy
Copy link
Contributor Author

@mbgower the test files are in accessibility-checker-engine/test/v2/checker/accessibility/rules/element_attribute_deprecated_ruleunit

@mbgower
Copy link
Contributor

mbgower commented Feb 28, 2022

met with Shunguo. Made minor changes to mdx file based on discussion.

@mbgower
Copy link
Contributor

mbgower commented Feb 28, 2022

@philljenkins In case you see this, decided to not have any Benefits section, as this is just a parsing issue. No group specifically benefits more than others, and listing them all seems tedious and potentially inaccurate.

@mbgower mbgower closed this as completed Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Issues in the accessibility-checker-engine component SME Discuss with subject matter experts
Projects
None yet
Development

No branches or pull requests

3 participants