-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rule Help]: deprecated elements, attributes, and aria-attributes #678
Comments
see box note https://ibm.ent.box.com/notes/919138089437. Please first review and finalize the messages. |
@mbgower in case you need, the dev branch is https://github.com/IBMa/equal-access/tree/dev-608 |
I will be starting on this today |
@shunguo, do you create an array of attributes that are deprecated and report them all in the event of a failure, or as you only listing the attribute used? I would assume the latter, so I have made the failure messages all singular. |
@shunguoy I do not see any existing mdx help file for either RPT_Elem_Deprecated OR element_attribute_deprecated. The box note says it is an existing rule, so I assume the mdx file exists but has a different name? |
I have made some commits in a new branch off yours https://github.com/IBMa/equal-access/tree/rpt_element_attribute_deprecated_help |
@philljenkins do you have any backstory on this? |
@mbgower this rule doesn't have a help currently. Although it's an existing rule, it's currently not triggered. |
@mbgower the message file is in the accessibility-checker-engine/src/v2/checker/accessibility/nls/index.ts. You can either make the message change directly, or you can send me the messages for me to make the change. |
@mbgower the test files are in accessibility-checker-engine/test/v2/checker/accessibility/rules/element_attribute_deprecated_ruleunit |
met with Shunguo. Made minor changes to mdx file based on discussion. |
@philljenkins In case you see this, decided to not have any Benefits section, as this is just a parsing issue. No group specifically benefits more than others, and listing them all seems tedious and potentially inaccurate. |
Project
a11y checker engine
Browser
Chrome
Operating system
MacOS
Description
This is to enhance the RPT_Elem_Deprecated rule:
Steps to reproduce
test in the extension
The text was updated successfully, but these errors were encountered: