Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit: input_haspopup_conflict - can we tighten scope? #1622

Closed
tombrunet opened this issue Aug 29, 2023 · 1 comment · Fixed by #1917
Closed

Revisit: input_haspopup_conflict - can we tighten scope? #1622

tombrunet opened this issue Aug 29, 2023 · 1 comment · Fixed by #1917
Assignees
@shunguoy
Labels
engine Issues in the accessibility-checker-engine component priority-3 (low) Ready for QA

Comments

@tombrunet
Copy link
Member

tombrunet commented Aug 29, 2023 •
edited
Loading

This rule fires some "Needs review" items. Can we identify scenarios where this definitely passes so that we can tighten the scope and trigger fewer "Needs Review" items for this.
@tombrunet tombrunet added engine Issues in the accessibility-checker-engine component priority-3 (low) labels Aug 29, 2023
shunguoy added a commit that referenced this issue Jun 5, 2024
@shunguoy
update the rule and test cases #1622
9201733
@shunguoy shunguoy mentioned this issue Jun 5, 2024
Merged
5 tasks
shunguoy added a commit that referenced this issue Jun 6, 2024
@shunguoy
update the test result #1622
a809f4d
@philljenkins
Copy link
Contributor

philljenkins commented Jun 18, 2024 •
edited
Loading

Previous messages were:

image

Messages now display as follows:

Screenshot 2024-06-18 at 4 44 28 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shunguoy shunguoy

Labels
engine Issues in the accessibility-checker-engine component priority-3 (low) Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixrule(input_haspopup_conflict): Add additional checks and update the messages IBMa/equal-access
3 participants
@philljenkins @shunguoy @tombrunet