Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): Minor update to example code in the README #9

Merged
merged 2 commits into from
Jul 6, 2020
Merged

fix(doc): Minor update to example code in the README #9

merged 2 commits into from
Jul 6, 2020

Conversation

srowles
Copy link
Contributor

@srowles srowles commented Jul 2, 2020

Simple options would be more "go like" to be inlined with the calls.

I've also included getting the API key from os.GetEnv rather than people adding it to code to avoid risk of committing an API key by mistake

Copy link
Member

@astha-jain astha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for putting a PR.

@astha-jain astha-jain changed the title Minor update to example code in the README fix(doc): Minor update to example code in the README Jul 6, 2020
@astha-jain astha-jain merged commit f3841fc into IBM:master Jul 6, 2020
ibm-vpc pushed a commit that referenced this pull request Jul 6, 2020
## [0.0.2](v0.0.1...v0.0.2) (2020-07-06)

### Bug Fixes

* **doc:** Minor update to example code in the README ([#9](#9)) ([f3841fc](f3841fc))
@ibm-vpc
Copy link

ibm-vpc commented Jul 6, 2020

🎉 This PR is included in version 0.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants