Avoid recursive copy in ApplpyMetric for cases of a single metric #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafnapension
force-pushed
the
no_snapshot_on_entrance_to_applymetric
branch
from
8b1ea27
to
190dfa4
Compare
dafnapension
changed the title
dafnapension
force-pushed
the
no_snapshot_on_entrance_to_applymetric
branch
5 times, most recently
from
7fe49f5
to
482cf38
Compare
…only in cases of two or more metrics, because that recursive copy is only needed against one metric changing stream contents before another metric is applied. Signed-off-by: dafnapension <[email protected]>
dafnapension
force-pushed
the
no_snapshot_on_entrance_to_applymetric
branch
from
482cf38
to
7191512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because that recursive copy is only needed against one metric changing stream contents before another metric is applied.
So overall: payless in time and space for all cases of a single metric.
Earn a few cents in Performance.