Improve log messages around the max sequence length #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the router the error message was rephrased to make it more understandable for users who arent familiar with the internals. In the server we now print the maximum possible sequence length limited by the model sequence length. The existing print was showing how much output tokens can fit into the memory if you pass max_sequence_length input tokens and vice-versa. I don't know what I was thinking when I wrote that. Signed-off-by: Max de Bayser <[email protected]>
joerunde
reviewed
Jun 27, 2024
joerunde
approved these changes
Jun 27, 2024
Remove mention to `max_batch_weight` so as not to confuse users. Signed-off-by: Maximilien de Bayser <[email protected]>
Signed-off-by: Maximilien de Bayser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The existing messages were confusing to the users.
Modifications
In the router the error message was rephrased to make it more understandable for users who arent familiar with the internals.
In the server we now print the maximum possible sequence length limited by the model sequence length. The existing print was showing how much output tokens can fit into the memory if you pass max_sequence_length input tokens and vice-versa. I don't know what I was thinking when I wrote that.
Related Issues
https://github.ibm.com/ai-foundation/watson-fm-stack-tracker/issues/958