Use a local registry for metrics #744
Merged
+6
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
slaunay
commented
Sep 7, 2016
slaunay
commented
- use a new dedicated registry per config instead of using the default global registry provided by go-metrics
- update documentation and unit tests
- use a new dedicated registry per config instead of using the default global registry provided by go-metrics - update documentation and unit tests
|
@justinas does this work for you? |
|
@eapache Absolutely. Package-global registry would be another alternative, but that's up to you :) |
|
Trying to stay away from package globals going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.