fix(test): use correct param and equivalence check #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test had never actually been making the correct assertion here as it was doing an always true `if assignableTopic == assignableTopic` check. After fixing that it became clear that the Test_stickyBalanceStrategy_Plan_ReassignmentWithRandomSubscriptionsAndChanges test was passing the wrong members parameter for its second phase. After fixing both of those the test passed and checked the correct state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test had never actually been making the correct assertion here as
it was doing an always true
if assignableTopic == assignableTopiccheck. After fixing that it became clear that the
Test_stickyBalanceStrategy_Plan_ReassignmentWithRandomSubscriptionsAndChanges
test was passing the wrong members parameter for its second phase. After
fixing both of those the test passed and checked the correct state.