Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Usage Reports): add "created_by_email_id" to Offer schema #274

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

Jdatechong
Copy link
Contributor

PR summary

updated offers to have the created_by_email_id field

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

updated offers to have the created_by_email_id field

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Test results:

test/unit/test_case_management_v1.py .....................................................................                             [  3%]
test/unit/test_catalog_management_v1.py .............................................................................................. [  7%]
...................................................................................................................................... [ 13%]
...................................................................................................................................... [ 20%]
...................................                                                                                                    [ 21%]
test/unit/test_common.py .                                                                                                             [ 21%]
test/unit/test_context_based_restrictions_v1.py ...................................................................................... [ 25%]
.................                                                                                                                      [ 26%]
test/unit/test_enterprise_billing_units_v1.py ..................................                                                       [ 28%]
test/unit/test_enterprise_management_v1.py .................................................................................           [ 32%]
test/unit/test_enterprise_usage_reports_v1.py ..............                                                                           [ 32%]
test/unit/test_global_catalog_v1.py .................................................................................                  [ 36%]
test/unit/test_global_search_v2.py ........                                                                                            [ 36%]
test/unit/test_global_tagging_v1.py .............................................                                                      [ 38%]
test/unit/test_iam_access_groups_v2.py ............................................................................................... [ 43%]
...................................................................................................................................... [ 49%]
..........................                                                                                                             [ 50%]
test/unit/test_iam_identity_v1.py .................................................................................................... [ 55%]
...................................................................................................................................... [ 61%]
...................................................................................................................................... [ 68%]
........................                                                                                                               [ 69%]
test/unit/test_iam_policy_management_v1.py ........................................................................................... [ 73%]
.......................................................................................................................                [ 79%]
test/unit/test_ibm_cloud_shell_v1.py ....                                                                                              [ 79%]
test/unit/test_open_service_broker_v1.py ...................................                                                           [ 80%]
test/unit/test_partner_billing_units_v1.py ........................                                                                    [ 82%]
test/unit/test_partner_usage_reports_v1.py .................                                                                           [ 82%]
test/unit/test_resource_controller_v2.py ............................................................................................. [ 87%]
................................................................                                                                       [ 90%]
test/unit/test_resource_manager_v2.py ....................................                                                             [ 91%]
test/unit/test_usage_metering_v4.py ......                                                                                             [ 92%]
test/unit/test_usage_reports_v4.py ................................................................................................... [ 96%]
.......                                                                                                                                [ 97%]
test/unit/test_user_management_v1.py ..............................................................                                    [100%]

=========================================================== 2137 passed in 58.59s ============================================================

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ Jdatechong
✅ pyrooka
❌ bssmetering
You have signed the CLA already but the status is still pending? Let us recheck it.

@pyrooka pyrooka changed the title feat(usage reports) add created_by_email_id to offer feat(Usage Reports): add "created_by_email_id" to Offer schema Sep 10, 2024
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The only question I have is: have you signed the CLA?

Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jdatechong Please re-gen the code by using the latest version of the generator. Thank you!

@Jdatechong Jdatechong requested a review from pyrooka October 18, 2024 17:47
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good!

@pyrooka pyrooka merged commit 099bad4 into IBM:main Oct 28, 2024
2 of 3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Oct 28, 2024
# [0.59.0](v0.58.0...v0.59.0) (2024-10-28)

### Features

* **Usage Reports:** add "created_by_email_id" to Offer schema ([#274](#274)) ([099bad4](099bad4))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.59.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants