-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Usage Reports): add "created_by_email_id" to Offer schema #274
Conversation
|
Signed-off-by: Jonathan Date-chong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The only question I have is: have you signed the CLA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jdatechong Please re-gen the code by using the latest version of the generator. Thank you!
Signed-off-by: Jonathan Date-chong <[email protected]>
Signed-off-by: Jonathan Date-chong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are looking good!
# [0.59.0](v0.58.0...v0.59.0) (2024-10-28) ### Features * **Usage Reports:** add "created_by_email_id" to Offer schema ([#274](#274)) ([099bad4](099bad4))
🎉 This PR is included in version 0.59.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
updated offers to have the created_by_email_id field
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
updated offers to have the created_by_email_id field
Does this PR introduce a breaking change?
Other information
Test results: