Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Global Catalog): re-gen service and add examples #76

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Conversation

padamstx
Copy link
Member

PR summary

This PR contains a re-gen of the Global Catalog service plus new working examples.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx self-assigned this Feb 15, 2021
@codecov
Copy link

codecov bot commented Feb 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@7fccc58). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             main       #76   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        19           
  Lines           ?      2898           
  Branches        ?       369           
========================================
  Hits            ?      2898           
  Misses          ?         0           
  Partials        ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fccc58...1bfb40c. Read the comment docs.

@padamstx padamstx force-pushed the gc-examples branch 3 times, most recently from 09a446c to 9cd73be Compare February 17, 2021 22:35
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 484a380 into main Feb 18, 2021
@padamstx padamstx deleted the gc-examples branch February 18, 2021 22:31
ibm-devx-automation pushed a commit that referenced this pull request Feb 18, 2021
## [0.17.10](v0.17.9...v0.17.10) (2021-02-18)

### Bug Fixes

* **Global Catalog:** re-gen service and add examples ([#76](#76)) ([484a380](484a380))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants