Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Enterprise Management): re-gen service after update trait object #213

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

namratabhadauriya
Copy link
Contributor

@namratabhadauriya namratabhadauriya commented Jul 3, 2023

PR summary

re-gen service after update trait object

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx self-requested a review July 5, 2023 14:25
@padamstx padamstx self-assigned this Jul 5, 2023
@padamstx
Copy link
Member

padamstx commented Jul 5, 2023

@namratabhadauriya Need to fix the "signed off by" check failure, plus there are lint errors. See "update_service.md" for steps to fix.

@namratabhadauriya namratabhadauriya force-pushed the update-enterprise-management branch from a31c483 to fae76bb Compare July 5, 2023 15:17
@namratabhadauriya namratabhadauriya force-pushed the update-enterprise-management branch from fae76bb to a3b4e5b Compare July 5, 2023 15:36
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit b772a4b into main Jul 5, 2023
@padamstx padamstx deleted the update-enterprise-management branch July 5, 2023 17:36
ibm-devx-sdk pushed a commit that referenced this pull request Jul 5, 2023
# [0.38.0](v0.37.0...v0.38.0) (2023-07-05)

### Features

* **Enterprise Management:** re-gen service after update trait object ([#213](#213)) ([b772a4b](b772a4b))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants