Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Usage Reports): Update Account Summary #211

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Conversation

Jdatechong
Copy link
Contributor

PR summary

Updates Account Summary to reflect changes to the API

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Updates Account Summary to reflect changes to the API

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Integration tests:

PASS  test/integration/usage-reports.v4.test.js (7.138 s)
---------------|---------|----------|---------|---------|-------------------------------------------------------------------------------------------------------
File           | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                                                                     
---------------|---------|----------|---------|---------|-------------------------------------------------------------------------------------------------------
All files      |   57.33 |     12.9 |   55.55 |   58.96 |                                                                                                       
 lib           |     100 |      100 |     100 |     100 |                                                                                                       
  common.ts    |     100 |      100 |     100 |     100 |                                                                                                       
 usage-reports |   55.34 |     12.9 |   53.84 |   56.93 |                                                                                                       
  v4.ts        |   55.34 |     12.9 |   53.84 |   56.93 | ...193,1201,1209-1229,1237-1242,1270-1277,1285,1293-1313,1321-1326,1351-1358,1366,1374-1394,1402-1407 
---------------|---------|----------|---------|---------|-------------------------------------------------------------------------------------------------------

Test Suites: 1 passed, 1 total
Tests:       7 passed, 7 total
Snapshots:   0 total
Time:        7.28 s
Ran all test suites matching /test\/integration\/usage-reports.v4.test.js/i.

Tests:

PASS  test/unit/resource-manager.v2.test.js (10.667 s)


 PASS  test/unit/open-service-broker.v1.test.js (10.637 s)


 PASS  test/unit/global-tagging.v1.test.js (10.72 s)


 PASS  test/unit/global-catalog.v1.test.js (10.835 s)

 PASS  test/unit/context-based-restrictions.v1.test.js (10.906 s)



 PASS  test/unit/iam-policy-management.v1.test.js (11.077 s)

 PASS  test/unit/common.test.js
 PASS  test/unit/iam-identity.v1.test.js (11.715 s)
 PASS  test/unit/ibm-cloud-shell.v1.test.js
 PASS  test/unit/usage-metering.v4.test.js
 PASS  test/unit/global-search.v2.test.js
 PASS  test/unit/enterprise-billing-units.v1.test.js (12.428 s)
 PASS  test/unit/user-management.v1.test.js (12.463 s)
 PASS  test/unit/case-management.v1.test.js (12.471 s)
 PASS  test/unit/catalog-management.v1.test.js (12.504 s)
 PASS  test/unit/usage-reports.v4.test.js (12.506 s)
 PASS  test/unit/enterprise-management.v1.test.js (12.528 s)
 PASS  test/unit/iam-access-groups.v2.test.js (12.55 s)
 PASS  test/unit/enterprise-usage-reports.v1.test.js
 PASS  test/unit/resource-controller.v2.test.js (12.647 s)
----------------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------
File                        | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                                                        
----------------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------
All files                   |    98.6 |    87.56 |     100 |   98.57 |                                                                                          
 case-management            |    98.8 |    88.46 |     100 |   98.78 |                                                                                          
  v1.ts                     |    98.8 |    88.46 |     100 |   98.78 | 129,1246,1269                                                                            
 catalog-management         |     100 |       98 |     100 |     100 |                                                                                          
  v1.ts                     |     100 |       98 |     100 |     100 | 86,4576                                                                                  
 context-based-restrictions |   98.42 |    88.09 |     100 |   98.42 |                                                                                          
  v1.ts                     |   98.42 |    88.09 |     100 |   98.42 | 142,499,580                                                                              
 enterprise-billing-units   |    96.4 |    79.06 |     100 |   96.15 |                                                                                          
  v1.ts                     |    96.4 |    79.06 |     100 |   96.15 | 185,594,617,676,699                                                                      
 enterprise-management      |   96.97 |     79.1 |     100 |   96.84 |                                                                                          
  v1.ts                     |   96.97 |     79.1 |     100 |   96.84 | 209,547,853,1467,1490,1549,1572,1631,1654                                                
 enterprise-usage-reports   |   95.89 |    78.57 |     100 |   95.58 |                                                                                          
  v1.ts                     |   95.89 |    78.57 |     100 |   95.58 | 147,388,411                                                                              
 global-catalog             |     100 |    94.28 |     100 |     100 |                                                                                          
  v1.ts                     |     100 |    94.28 |     100 |     100 | 88,1166                                                                                  
 global-search              |   98.18 |     87.5 |     100 |   98.14 |                                                                                          
  v2.ts                     |   98.18 |     87.5 |     100 |   98.14 | 180                                                                                      
 global-tagging             |   98.54 |    92.15 |     100 |   98.52 |                                                                                          
  v1.ts                     |   98.54 |    92.15 |     100 |   98.52 | 162,309                                                                                  
 iam-access-groups          |   98.74 |    86.66 |     100 |    98.7 |                                                                                          
  v2.ts                     |   98.74 |    86.66 |     100 |    98.7 | 2113,2136,2194,2217                                                                      
 iam-identity               |   99.36 |    93.15 |     100 |   99.36 |                                                                                          
  v1.ts                     |   99.36 |    93.15 |     100 |   99.36 | 147,284,612                                                                              
 iam-policy-management      |   99.61 |    95.52 |     100 |   99.61 |                                                                                          
  v1.ts                     |   99.61 |    95.52 |     100 |   99.61 | 651                                                                                      
 ibm-cloud-shell            |     100 |     92.3 |     100 |     100 |                                                                                          
  v1.ts                     |     100 |     92.3 |     100 |     100 | 83                                                                                       
 lib                        |     100 |      100 |     100 |     100 |                                                                                          
  common.ts                 |     100 |      100 |     100 |     100 |                                                                                          
 open-service-broker        |     100 |    94.44 |     100 |     100 |                                                                                          
  v1.ts                     |     100 |    94.44 |     100 |     100 | 83                                                                                       
 resource-controller        |   96.79 |    79.41 |     100 |   96.62 |                                                                                          
  v2.ts                     |   96.79 |    79.41 |     100 |   96.62 | ...,1092,1405,1757,2746,2769,2828,2851,2910,2933,2992,3015,3074,3097,3156,3179,3238,3261 
 resource-manager           |     100 |    93.33 |     100 |     100 |                                                                                          
  v2.ts                     |     100 |    93.33 |     100 |     100 | 85                                                                                       
 usage-metering             |     100 |    91.66 |     100 |     100 |                                                                                          
  v4.ts                     |     100 |    91.66 |     100 |     100 | 87                                                                                       
 usage-reports              |    97.2 |    82.25 |     100 |   97.02 |                                                                                          
  v4.ts                     |    97.2 |    82.25 |     100 |   97.02 | 1187,1210,1271,1294,1352,1375                                                            
 user-management            |    98.2 |    82.85 |     100 |   98.14 |                                                                                          
  v1.ts                     |    98.2 |    82.85 |     100 |   98.14 | 483,1003,1026                                                                            
----------------------------|---------|----------|---------|---------|------------------------------------------------------------------------------------------

Test Suites: 20 passed, 20 total
Tests:       1171 passed, 1171 total
Snapshots:   0 total
Time:        13.858 s
Ran all test suites matching /test\/unit\//i.

@padamstx padamstx self-requested a review May 31, 2023 22:29
@padamstx padamstx self-assigned this May 31, 2023
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit b3f6f0a into IBM:main Jun 1, 2023
ibm-devx-sdk pushed a commit that referenced this pull request Jun 1, 2023
# [0.36.0](v0.35.0...v0.36.0) (2023-06-01)

### Features

* **Usage Reports:** Update Account Summary ([#211](#211)) ([b3f6f0a](b3f6f0a))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants