-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IAM Policy Management): Add support for policy templates #209
Conversation
…ments to match API definition Signed-off-by: Shaun Colley <[email protected]>
Signed-off-by: Shaun Colley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving as the code looks fine (functional) as is. However, I'll just repeat my comment as in the other PRs... i.e. we need to update the API definition with links and example values to improve the generation of int tests and examples.
@@ -57,6 +57,10 @@ describe('IamPolicyManagementV1', () => { | |||
let examplePolicyETag; | |||
let exampleCustomRoleId; | |||
let exampleCustomRoleEtag; | |||
let exampleTemplateId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments here re: links and example values.
@swcolley Could you please update your branch with main? Looks like there is will be a merge conflict in package-lock.json, however. Thanks! |
Signed-off-by: Vivek.Jain3 <[email protected]>
# [0.41.0](v0.40.1...v0.41.0) (2023-09-05) ### Features * **IAM Policy Management:** add support for policy templates ([#209](#209)) ([5e72f45](5e72f45))
🎉 This PR is included in version 0.41.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
PR summary
Added feature support for Enterprise IAM work, policy templates and get template assigments.
Issue: https://github.ibm.com/IAM/AM-issues/issues/1346
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
SDK adopters will be able to call policy template and assignment APIs.
Does this PR introduce a breaking change?
Other information
API defintion:
Staging
Prod
Test information:
Example Tests:
Integration Tests: