Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Policy Management): Add support for policy templates #209

Merged
merged 9 commits into from
Sep 5, 2023

Conversation

swcolley
Copy link
Contributor

PR summary

Added feature support for Enterprise IAM work, policy templates and get template assigments.

Issue: https://github.ibm.com/IAM/AM-issues/issues/1346

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

SDK adopters will be able to call policy template and assignment APIs.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

API defintion:
Staging
Prod

Test information:

Example Tests:

Test Suites: 1 passed, 1 total
Tests:       28 passed, 28 total
Snapshots:   0 total
Time:        10.713 s
Ran all test suites matching /examples\/iam-policy-management.v1.test.js/i.

Integration Tests:

Test Suites: 1 passed, 1 total
Tests:       30 passed, 30 total
Snapshots:   0 total
Time:        18.706 s, estimated 27 s
Ran all test suites matching /test\/integration\/iam-policy-management.v1.test.js/i.

@swcolley swcolley changed the title Policy template feat(IAM Policy Management): Add support for policy templates May 26, 2023
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving as the code looks fine (functional) as is. However, I'll just repeat my comment as in the other PRs... i.e. we need to update the API definition with links and example values to improve the generation of int tests and examples.

@@ -57,6 +57,10 @@ describe('IamPolicyManagementV1', () => {
let examplePolicyETag;
let exampleCustomRoleId;
let exampleCustomRoleEtag;
let exampleTemplateId;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments here re: links and example values.

@padamstx padamstx self-assigned this Jun 21, 2023
@padamstx
Copy link
Member

@swcolley Could you please update your branch with main? Looks like there is will be a merge conflict in package-lock.json, however. Thanks!

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2023

CLA assistant check
All committers have signed the CLA.

@padamstx padamstx merged commit 5e72f45 into main Sep 5, 2023
@padamstx padamstx deleted the policy-template branch September 5, 2023 16:44
ibm-devx-sdk pushed a commit that referenced this pull request Sep 5, 2023
# [0.41.0](v0.40.1...v0.41.0) (2023-09-05)

### Features

* **IAM Policy Management:** add support for policy templates ([#209](#209)) ([5e72f45](5e72f45))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants