Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Global Search/Tagging): regenerated services with latest API definition #190

Merged
merged 12 commits into from
Jan 17, 2023

Conversation

fabrizio-leoni
Copy link
Contributor

Signed-off-by: Fabrizio Leoni [email protected]

PR summary

SDK regenerated API definition starting from https://test.cloud.ibm.com/apidocs/tagging https://test.cloud.ibm.com/apidocs/search

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@fabrizio-leoni
Copy link
Contributor Author

fabrizio-leoni commented Dec 21, 2022

@padamstx

  1. It is right the exposure of fields relative to admin user usage?
  2. Why the generator created a code that does not pass the lint?

@fabrizio-leoni
Copy link
Contributor Author

@padamstx

This is the last version of PR. Can you review this please?

@padamstx padamstx self-requested a review December 21, 2022 15:18
@padamstx padamstx self-assigned this Dec 21, 2022
@fabrizio-leoni
Copy link
Contributor Author

image

@fabrizio-leoni
Copy link
Contributor Author

image

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 717ecd2 into IBM:main Jan 17, 2023
ibm-devx-sdk pushed a commit that referenced this pull request Jan 17, 2023
## [0.30.2](v0.30.1...v0.30.2) (2023-01-17)

### Bug Fixes

* **Global Search & Tagging:** regen services with latest API definition ([#190](#190)) ([717ecd2](717ecd2))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.30.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants