Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CBR): add support for the X-Correlation-Id header #145

Merged
merged 1 commit into from
Nov 3, 2021
Merged

feat(CBR): add support for the X-Correlation-Id header #145

merged 1 commit into from
Nov 3, 2021

Conversation

zhenwan
Copy link
Member

@zhenwan zhenwan commented Nov 3, 2021

PR summary

  • Added support for passing the standard X-Correlation-Id header in each request

  • Updated some swagger properties summaries and descriptions

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

This enhancement adds support for passing the standard X-Correlation-Id header in each request. This is an optional header and it does not break backward compatibility.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@zhenwan
Copy link
Member Author

zhenwan commented Nov 3, 2021

Unit test result:
image
Integration Test result:
image

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #145 (6087f3e) into main (c2bd976) will not change coverage.
The diff coverage is n/a.

❗ Current head 6087f3e differs from pull request most recent head fa9fe92. Consider uploading reports for the commit fa9fe92 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #145   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         3643      3643           
  Branches       446       446           
=========================================
  Hits          3643      3643           
Impacted Files Coverage Δ
context-based-restrictions/v1.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f913228...fa9fe92. Read the comment docs.

@padamstx padamstx self-requested a review November 3, 2021 20:54
@padamstx padamstx self-assigned this Nov 3, 2021
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@padamstx padamstx merged commit 0f66331 into IBM:main Nov 3, 2021
ibm-devx-sdk pushed a commit that referenced this pull request Nov 3, 2021
## [0.22.2](v0.22.1...v0.22.2) (2021-11-03)

### Bug Fixes

* **Context-Based Restrictions:** add support for the X-Correlation-Id header ([#145](#145)) ([0f66331](0f66331))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.22.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants