Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(IBM Cloud Shell): re-gen service to adopt the new error toolchain #365

Merged
merged 1 commit into from
Nov 29, 2024
Merged

feat(IBM Cloud Shell): re-gen service to adopt the new error toolchain #365

merged 1 commit into from
Nov 29, 2024
+243 −206

Conversation

Afreen1998
Copy link
Contributor

@Afreen1998 Afreen1998 commented Nov 28, 2024 •
edited by pyrooka
Loading

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Afreen1998
Copy link
Contributor Author

@padamstx created a fresh PR - still the checks are not passing. Anything else to be done here ?

pyrooka
pyrooka reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what happened to the builds, but I tested the changes in my local machine and they run fine. I left 3 comments and once they are solved, I can merge this PR.

ibmcloudshellv1/ibm_cloud_shell_v1_examples_test.go Show resolved Hide resolved
ibmcloudshellv1/ibm_cloud_shell_v1_integration_test.go Show resolved Hide resolved
ibmcloudshellv1/ibm_cloud_shell_v1_suite_test.go Show resolved Hide resolved
@pyrooka pyrooka self-assigned this Nov 29, 2024
pyrooka
pyrooka approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, tests run fine locally.

@pyrooka pyrooka merged commit 19271ad into IBM:main Nov 29, 2024
2 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Nov 29, 2024
@semantic-release-bot
chore(release): 0.72.0 release notes [skip ci]
f101f2f 
# [0.72.0](v0.71.2...v0.72.0) (2024-11-29)

### Features

* **IBM Cloud Shell:** re-gen service for adopting the new error toolchain ([#365](#365)) ([19271ad](19271ad))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.72.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrooka pyrooka pyrooka approved these changes

Assignees

@pyrooka pyrooka

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Afreen1998 @ibm-devx-sdk @pyrooka