Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Catalog Management): re-gen service after recent API changes #353

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

benbuchanan
Copy link
Contributor

PR summary

Regenerating after recent API changes

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

No modifications, just adding new endpoints and parameters.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

examples:

Ran 781 of 811 Specs in 69.986 seconds
SUCCESS! -- 781 Passed | 0 Failed | 0 Pending | 30 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/catalogmanagementv1	70.583s

integration:

Ran 793 of 849 Specs in 64.187 seconds
SUCCESS! -- 793 Passed | 0 Failed | 0 Pending | 56 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/catalogmanagementv1	64.627s

@benbuchanan benbuchanan requested a review from padamstx September 5, 2024 14:54
@pyrooka pyrooka requested review from pyrooka and removed request for padamstx September 5, 2024 15:07
@pyrooka pyrooka self-assigned this Sep 5, 2024
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left 2 minor comments that should be addressed before merging. I approve the PR now to avoid the re-review.

@@ -3346,6 +3501,22 @@ var _ = Describe(`CatalogManagementV1 Integration Tests`, func() {
})
})

// Ounset pc managed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a typo here, right?

Suggested change
// Ounset pc managed
// Unset pc managed

@@ -1774,6 +1976,17 @@ var _ = Describe(`CatalogManagementV1 Examples Tests`, func() {
Expect(response.StatusCode).To(Equal(200))
})

// unset pc managed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is really-really small, but please change to make it sync with the comment in the integration tests. :)

Suggested change
// unset pc managed
// Unset pc managed

@pyrooka pyrooka changed the title feat(Catalog Management): regen after recent api changes feat(Catalog Management): re-gen service after recent API changes Sep 6, 2024
@pyrooka pyrooka merged commit 41163ad into IBM:main Sep 6, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Sep 6, 2024
# [0.69.0](v0.68.1...v0.69.0) (2024-09-06)

### Features

* **Catalog Management:** re-gen service after recent API changes ([#353](#353)) ([41163ad](41163ad))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.69.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants