-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Catalog Management): re-gen service after recent API changes #353
Conversation
Signed-off-by: Ben Buchanan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left 2 minor comments that should be addressed before merging. I approve the PR now to avoid the re-review.
@@ -3346,6 +3501,22 @@ var _ = Describe(`CatalogManagementV1 Integration Tests`, func() { | |||
}) | |||
}) | |||
|
|||
// Ounset pc managed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a typo here, right?
// Ounset pc managed | |
// Unset pc managed |
@@ -1774,6 +1976,17 @@ var _ = Describe(`CatalogManagementV1 Examples Tests`, func() { | |||
Expect(response.StatusCode).To(Equal(200)) | |||
}) | |||
|
|||
// unset pc managed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is really-really small, but please change to make it sync with the comment in the integration tests. :)
// unset pc managed | |
// Unset pc managed |
Signed-off-by: Ben Buchanan <[email protected]>
# [0.69.0](v0.68.1...v0.69.0) (2024-09-06) ### Features * **Catalog Management:** re-gen service after recent API changes ([#353](#353)) ([41163ad](41163ad))
🎉 This PR is included in version 0.69.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
Regenerating after recent API changes
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
No modifications, just adding new endpoints and parameters.
Does this PR introduce a breaking change?
Other information
examples:
integration: