-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IAM Policy Management): add access management account settings API #330
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Shaun Colley <[email protected]>
Signed-off-by: Shaun Colley <[email protected]>
Latest testing after re-gen: go test -tags=integration
Running Suite: IamPolicyManagementV1 Suite
==========================================
Random Seed: 1717527298
Will run 280 of 280 specs
•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 280 of 280 Specs in 39.400 seconds
SUCCESS! -- 280 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok github.com/IBM/platform-services-go-sdk/iampolicymanagementv1 40.180s
go test -tags=examples
Running Suite: IamPolicyManagementV1 Suite
==========================================
Random Seed: 1717527387
Will run 279 of 279 specs
••
CreatePolicy() result:
...
GetSettings() result:
{
"external_account_identity_interaction": {
"identity_types": {
"user": {
"state": "monitor",
"external_allowed_accounts": []
},
"service_id": {
"state": "monitor",
"external_allowed_accounts": []
},
"service": {
"state": "monitor",
"external_allowed_accounts": []
}
}
}
}
•
UpdateSettings() result:
{
"external_account_identity_interaction": {
"identity_types": {
"user": {
"state": "monitor",
"external_allowed_accounts": []
},
"service_id": {
"state": "monitor",
"external_allowed_accounts": []
},
"service": {
"state": "monitor",
"external_allowed_accounts": []
}
}
}
}
••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 279 of 279 Specs in 37.372 seconds
SUCCESS! -- 279 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok github.com/IBM/platform-services-go-sdk/iampolicymanagementv1 38.004s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@swcolley Shaun, just a reminder about this PR. Not sure if you really do need it merged at some point or if it might have dropped off your radar. |
@padamstx |
This PR will be needed, but for now I'm closing and I can re-open PR when the feature is ready to be delivered. |
@swcolley No worries, just wanted bring this up in case it fell through the cracks. |
Thank you 😄 |
Reopening to be worked. I need to update from master and resolve conflicts. Will also re-run test suite. Opening as a draft for now. |
PR summary
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Adds new Access Management Account Settings API (GET and PATCH paths)
Does this PR introduce a breaking change?
Other information
Issue: https://github.ibm.com/IAM/AM-issues/issues/2506
Integration tests:
Examples: