Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Policy Management): add access management account settings API #330

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

swcolley
Copy link
Contributor

@swcolley swcolley commented Jun 3, 2024

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Adds new Access Management Account Settings API (GET and PATCH paths)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Issue: https://github.ibm.com/IAM/AM-issues/issues/2506

Integration tests:

go test -tags=integration
Running Suite: IamPolicyManagementV1 Suite
==========================================
Random Seed: 1717442301
Will run 249 of 249 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 249 of 249 Specs in 21.582 seconds
SUCCESS! -- 249 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/iampolicymanagementv1	21.996s

Examples:

go test -tags=examples
Running Suite: IamPolicyManagementV1 Suite
==========================================
Random Seed: 1717442393
Will run 248 of 248 specs

••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
...
GetSettings() result:
{
  "external_account_identity_interaction": {
    "identity_types": {
      "user": {
        "state": "monitor",
        "external_allowed_accounts": []
      },
      "service_id": {
        "state": "monitor",
        "external_allowed_accounts": []
      },
      "service": {
        "state": "monitor",
        "external_allowed_accounts": []
      }
    }
  }
}
•
UpdateSettings() result:
{
  "external_account_identity_interaction": {
    "identity_types": {
      "user": {
        "state": "monitor",
        "external_allowed_accounts": []
      },
      "service_id": {
        "state": "monitor",
        "external_allowed_accounts": []
      },
      "service": {
        "state": "monitor",
        "external_allowed_accounts": []
      }
    }
  }
}
•
Ran 248 of 248 Specs in 36.528 seconds
SUCCESS! -- 248 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/iampolicymanagementv1	36.933s

@CLAassistant
Copy link

CLAassistant commented Jun 3, 2024

CLA assistant check
All committers have signed the CLA.

@padamstx padamstx self-requested a review June 4, 2024 17:13
@padamstx padamstx self-assigned this Jun 4, 2024
@padamstx padamstx changed the title feat(IAM Policy Management): Add Access Management Account Settings API feat(IAM Policy Management): add access management account settings API Jun 4, 2024
@swcolley
Copy link
Contributor Author

swcolley commented Jun 4, 2024

Latest testing after re-gen:

go test -tags=integration
Running Suite: IamPolicyManagementV1 Suite
==========================================
Random Seed: 1717527298
Will run 280 of 280 specs

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 280 of 280 Specs in 39.400 seconds
SUCCESS! -- 280 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/iampolicymanagementv1	40.180s
go test -tags=examples                             
Running Suite: IamPolicyManagementV1 Suite
==========================================
Random Seed: 1717527387
Will run 279 of 279 specs

••
CreatePolicy() result:
...
GetSettings() result:
{
  "external_account_identity_interaction": {
    "identity_types": {
      "user": {
        "state": "monitor",
        "external_allowed_accounts": []
      },
      "service_id": {
        "state": "monitor",
        "external_allowed_accounts": []
      },
      "service": {
        "state": "monitor",
        "external_allowed_accounts": []
      }
    }
  }
}
•
UpdateSettings() result:
{
  "external_account_identity_interaction": {
    "identity_types": {
      "user": {
        "state": "monitor",
        "external_allowed_accounts": []
      },
      "service_id": {
        "state": "monitor",
        "external_allowed_accounts": []
      },
      "service": {
        "state": "monitor",
        "external_allowed_accounts": []
      }
    }
  }
}
••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 279 of 279 Specs in 37.372 seconds
SUCCESS! -- 279 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok  	github.com/IBM/platform-services-go-sdk/iampolicymanagementv1	38.004s

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx marked this pull request as draft June 4, 2024 19:14
@padamstx
Copy link
Member

@swcolley Shaun, just a reminder about this PR. Not sure if you really do need it merged at some point or if it might have dropped off your radar.

@swcolley
Copy link
Contributor Author

@padamstx
Thanks for reminding me. I think we needed to wait for terraform changes, but I think those were put on hold. We haven't merged production docs yet for this either. We need to wait. Let me confirm with team what plan is for this feature.

@swcolley
Copy link
Contributor Author

@padamstx

This PR will be needed, but for now I'm closing and I can re-open PR when the feature is ready to be delivered.

@swcolley swcolley closed this Aug 20, 2024
@padamstx
Copy link
Member

@swcolley No worries, just wanted bring this up in case it fell through the cracks.

@swcolley
Copy link
Contributor Author

Thank you 😄
I think we're planning on resuming/enabling in Q4, but that is still a bit of time, so I think closing this PR for now is best.

@swcolley swcolley reopened this Nov 19, 2024
@swcolley
Copy link
Contributor Author

Reopening to be worked. I need to update from master and resolve conflicts. Will also re-run test suite. Opening as a draft for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants