-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IAM Identity): add trusted profile identities api #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but just found a misspelled variable in the examples code.
ProfileID: &profileId, | ||
} | ||
|
||
profileIdnetities, response, err := iamIdentityService.GetProfileIdentities(&getProfileIdentitiesOptions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a manual change? Not sure how else this variable could become misspelled :)
profileIdnetities, response, err := iamIdentityService.GetProfileIdentities(&getProfileIdentitiesOptions) | |
profileIdentities, response, err := iamIdentityService.GetProfileIdentities(&getProfileIdentitiesOptions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I clicked on Approve by mistake. Just need to fix the one misspelled variable in the examples code.
Signed-off-by: Somanath Chavan <[email protected]>
7cc865a
to
477547a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# [0.40.0](v0.39.0...v0.40.0) (2023-06-12) ### Features * **IAM Identity:** add trusted profile identities API ([#262](#262)) ([b4dcf90](b4dcf90))
🎉 This PR is included in version 0.40.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
Added feature support for Trusted Profile identities work, add, get, delete identities associated with the profile.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
SDK adopters will be able to call Trusted profile identities APIs.
Does this PR introduce a breaking change?
Other information
API defintion:
Staging
Test information:
Integration Tests: