Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Identity): add trusted profile identities api #262

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

Somchavan
Copy link
Contributor

PR summary

Added feature support for Trusted Profile identities work, add, get, delete identities associated with the profile.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

SDK adopters will be able to call Trusted profile identities APIs.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

API defintion:
Staging

Test information:

Integration Tests:

Running Suite: IamIdentityV1 Suite
==================================
Random Seed: 1685636808
Will run 299 of 299 specs

+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Beginning teardown.
Finished teardown.

Ran 299 of 299 Specs in 37.665 seconds
SUCCESS! -- 299 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/iamidentityv1   38.110s

@Somchavan Somchavan requested a review from padamstx June 1, 2023 16:45
@padamstx padamstx self-assigned this Jun 7, 2023
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but just found a misspelled variable in the examples code.

ProfileID: &profileId,
}

profileIdnetities, response, err := iamIdentityService.GetProfileIdentities(&getProfileIdentitiesOptions)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a manual change? Not sure how else this variable could become misspelled :)

Suggested change
profileIdnetities, response, err := iamIdentityService.GetProfileIdentities(&getProfileIdentitiesOptions)
profileIdentities, response, err := iamIdentityService.GetProfileIdentities(&getProfileIdentitiesOptions)

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I clicked on Approve by mistake. Just need to fix the one misspelled variable in the examples code.

@Somchavan Somchavan force-pushed the iam-identity-profile-identities branch from 7cc865a to 477547a Compare June 9, 2023 09:40
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit b4dcf90 into main Jun 12, 2023
@padamstx padamstx deleted the iam-identity-profile-identities branch June 12, 2023 13:51
ibm-devx-sdk pushed a commit that referenced this pull request Jun 12, 2023
# [0.40.0](v0.39.0...v0.40.0) (2023-06-12)

### Features

* **IAM Identity:** add trusted profile identities API ([#262](#262)) ([b4dcf90](b4dcf90))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.40.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants