-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update vulnerable dependencies #166
Conversation
@barrett-schonefeld The two dependabot alerts that we're seeing in the node core indicate that the following dependency upgrades need to be made:
I don't think your proposed changes address either of those, do they? In fact, I'm not really seeing any version # changes at all... looks like the only changes are the removal of the "bundled" lines from package-lock.json. I'll go ahead and merge in the semver-regex-related PR that was opened up by dependabot automatically, as that will at least address one of the vulnerabilities. |
a7b8c42
to
3abaf17
Compare
Not initially, but now I updated
I rebased after you merged the |
I need to update some of the tests to work with the latest version of |
Removed the use of done in async tests because For more information on this change, see this Jest issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for doing this, Barrett. Glad to finally be rid of the redundant done()
calls 🙂
Details can be found here: IBM/node-sdk-core#166 The mentioned PR belongs to https://github.com/IBM/node-sdk-core
🎉 This PR is included in version 2.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Generated SDK source code using: - Generator version 3.26.0 - Specification version 1.0.0-dev0.0.31 - Automation (cloudant-sdks) version 26148a0
I updated to the latest version of
Jest
, which removes the dependency onset-value
.