add fix for import tracker compatibility with py3.11 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-l-hart
requested changes
Feb 19, 2024
import_tracker/import_tracker.py
Outdated
| @@ -322,9 +322,10 @@ def _get_value_col(dis_line: str) -> str: | |||
| def _get_op_number(dis_line: str) -> Optional[int]: | |||
| """Get the opcode number out of the line of `dis` output""" | |||
| line_parts = dis_line.split() | |||
| if not line_parts: | |||
| temp = [i for i, val in enumerate(line_parts) if val.isupper()] | |||
There was a problem hiding this comment.
Slight tightness suggestion (can't apply as a real suggestion over deleted lines I guess?)
if not (valid_line_part_idxs := [i for i, val in enumerate(line_parts) if val.isupper()]):
return None
opcode_idx = min(valid_line_parts)
added 2 commits
February 19, 2024 10:39
Signed-off-by: Xuancheng Fan <[email protected]>
Signed-off-by: Xuancheng Fan <[email protected]>
gabe-l-hart
approved these changes
Feb 19, 2024
3.7 compatible without walrus operator Signed-off-by: Gabe Goodhart <[email protected]>
gabe-l-hart
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#74