Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add function GetQueryParamAsInt #162

Merged
merged 1 commit into from
May 9, 2022
Merged

feat: add function GetQueryParamAsInt #162

merged 1 commit into from
May 9, 2022

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented May 9, 2022

This commit introduces the "GetQueryParamAsInt()"
utility function that will be used by generated
code to perform automatic pagination.
Similar to GetQueryParam, but also converts
the retrieved value to an int64.

@padamstx padamstx self-assigned this May 9, 2022
@padamstx padamstx requested a review from pyrooka May 9, 2022 17:11
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a really minor thing, looks good otherwise!

v5/core/utils.go Outdated Show resolved Hide resolved
This commit introduces the "GetQueryParamAsInt()"
utility function that will be used by generated
code to perform automatic pagination.
Similar to GetQueryParam, but also converts
the retrieved value to an int64.
@padamstx padamstx force-pushed the getqueryparamasint branch from 76086e4 to 48b4936 Compare May 9, 2022 20:28
@padamstx padamstx merged commit 2b4d018 into main May 9, 2022
@padamstx padamstx deleted the getqueryparamasint branch May 9, 2022 21:43
ibm-devx-sdk pushed a commit that referenced this pull request May 9, 2022
# [5.10.0](v5.9.5...v5.10.0) (2022-05-09)

### Features

* add function GetQueryParamAsInt ([#162](#162)) ([2b4d018](2b4d018))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants