Refactor zAppBuild reporting capabilities #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
dennis-behm
commented
Apr 13, 2023
utilities/ReportingUtilities.groovy
Outdated
|
|
||
| def Set<String> externalImpactList = collectionImpactsSetMap.get(cName) ?: new HashSet<String>() | ||
| // query dbb metadatastore for files with all logicalDependencies | ||
| def logicalImpactedFilesCollections = metadataStore.getImpactedFiles([cName], logicalDependencies); |
There was a problem hiding this comment.
Rather than querying for each individual collection name, pass the list of collections for which the filter applies.
Signed-off-by: Dennis Behm <[email protected]>
refactor_reporting_capabilities Conflicts: utilities/BuildUtilities.groovy Signed-off-by: Dennis Behm <[email protected]>
|
@M-DLB This is read for another review. I modified the code to actually leverage the new capabilities of the API to return a list of collections carrying the impacted files. |
M-DLB
reviewed
Apr 13, 2023
utilities/ReportingUtilities.groovy
Outdated
Comment on lines
138
to
141
| }else { | ||
| // debug-output | ||
| // println("$indentationMsg!* Skipped redundant analysis. $file was already or will be procceed soon.") | ||
| } |
There was a problem hiding this comment.
Do you need to keep the else here, if nothing is actually done?
Signed-off-by: Dennis Behm <[email protected]>
M-DLB
approved these changes
Apr 17, 2023
Merged
dennis-behm
added a commit
that referenced
this pull request
May 11, 2023
Moved the Reporting feature into in its own utilities file, and simplifying the query to check for impacted logical files across collections using DBB 2.0 APIs. Signed-off-by: Dennis Behm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reporting capabilities in zAppBuild were previously managed in the ImpactUtilities script. While this is a feature of zAppBuild, it does not need to be part of the ImpactUtils script.
This PR is