-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strategy to record logical files but skip scanning them #308
Conversation
Merge develop into main for zAppBuild 3.0.0 release
Release zAppBuild 3.0.1
Signed-off-by: Dennis Behm <[email protected]>
66101bf
to
be0b0fa
Compare
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Hi @dennis-behm - This looks good to me, just to confirm, why do you also define the |
@M-DLB - I kept in both places. The definition in |
200_skipscanning_signed Conflicts: build-conf/build.properties Signed-off-by: Dennis Behm <[email protected]>
@dennis-behm Sounds good yes, it makes sense keep it commented in file.properties in case of any override needed. |
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Release zAppBuild 3.1.0
Based on a discussion with @drbruce-git , I am going to change the implementation to use the |
Signed-off-by: Dennis Behm <[email protected]>
54f1614
to
cff561b
Compare
Signed-off-by: Dennis Behm <[email protected]>
exiting the process Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
@drbruce-git, please review the changes of this implementation. It is now moved to the |
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Release zAppBuild 3.2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dennis-behm - Would you be able to implement the suggested changes, especially about avoiding the JSON format :)
Thank you!
Signed-off-by: Dennis Behm <[email protected]>
200_skipscanning_signed Conflicts: utilities/BuildUtilities.groovy
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
Signed-off-by: Dennis Behm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dennis-behm Can you please check my comments on putting the script mappings into the default zAppBuild property file?
Signed-off-by: Dennis Behm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All OK to me. Thanks @dennis-behm
There are multiple artifacts which don't need to be scanned - for instance XML, JCL, PROCS and others. However, users would like to record them as a logical file to be able to use it in impact analysis, see also #200 .
Summary of changes:
This PR changes the behaviour of dbb-zappbuild: rather then always scanning with the default DependencyScanner, it requires the user to provide a mapping to determine the scanner. It uses the existing build property
dbb.scannerMapping
which was used to override the scanner for ZUnitConfiguration files, but always used the DependencyScanner as a default.At the same time, it reorganises the
build-conf
and introduces a new properties filedefaultApplicationSettings.properties
to define default application configurations. To preserve backward compatibility and not to break existing pipelines, a default dbb.scannerMapping is define in the new default application settings file.It removes the additional ScannerUtilities.groovy from the list of utilities, because it was only used for backward compatibility reasons. DBB 2.0 includes the ZUnitConfigScanner.