-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Type mergeBuild #152
Merged
Merged
Changes from 24 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
c1e2a04
implementation of a new build type --outgoingChangesBuild
dennis-behm 0df6c6a
fix syntax error
dennis-behm 0bd1091
removing argument from build option
dennis-behm 2e1a2a3
take the repoClient
dennis-behm e24aff6
preparing the buildSet by checking for script mappings
dennis-behm 366f023
fix syntax error
dennis-behm 4c6a3ff
update mainBuildBranch to the new branch name conventions
dennis-behm 8417610
rename build option to be mergeBuild
dennis-behm e706a9c
rename build option to be mergeBuild
dennis-behm df9ce8d
improve outputs
dennis-behm 510419b
skip rescanning source code
dennis-behm a981849
adding zunit test case for mergeBuild
dennis-behm 7d51f2d
adding test case for mergeBuild
dennis-behm 2f5dc27
modify mergeBuild scenario
dennis-behm c9e2294
documented build results
dennis-behm 6af1788
test config for merge build test case
dennis-behm 08e8964
supply changed application program sample
dennis-behm e6dc898
update replacement stratagy for changed file
dennis-behm 9a27283
documentation update
dennis-behm c341e31
update replacement stratagy for changed file
dennis-behm 40d1550
use epslis.bms for mergeBuild
dennis-behm 40f1f84
fix syntax
dennis-behm f2651ed
fix syntax
dennis-behm 856f7ba
skip print of output - this is available when a assert fails
dennis-behm 3d1be01
Update TOC including correct link
dennis-behm 233d2ae
Update documentation
dennis-behm 3915430
Merge remote-tracking branch 'upstream/develop' into
dennis-behm 94b3952
revert check for repoclient for fullbuild
dennis-behm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,112 @@ | ||
*********************************************************************** 00010000 | ||
EPSMLIS DFHMSD TYPE=&SYSPARM,MODE=INOUT,LANG=COBOL, X | ||
STORAGE=AUTO,TIOAPFX=YES,DSATTS=(COLOR,HILIGHT), X 0009000 | ||
MAPATTS=(COLOR,HILIGHT) 0009100 | ||
EPSMLIS DFHMDI SIZE=(24,80),CTRL=(PRINT,FREEKB) 0011000 | ||
DFHMDF POS=(1,24),LENGTH=26,INITIAL='Better Mortgage Rates', * | ||
ATTRB=(ASKIP,BRT) | ||
DFHMDF POS=(24,58),LENGTH=0, * | ||
ATTRB=ASKIP | ||
* MENU MORTGAGE LIST MERGE BUILD TEST. | ||
|
||
LITCOMP DFHMDF POS=(3,1),LENGTH=24,INITIAL='Company', * | ||
ATTRB=(ASKIP,NORM) | ||
LITPHN DFHMDF POS=(3,26),LENGTH=13,INITIAL='Phone Number', * | ||
ATTRB=(PROT,NORM) | ||
EPDIFF1 DFHMDF POS=(3,40),LENGTH=13,INITIAL='Interest Rate', * | ||
ATTRB=(PROT,NORM) | ||
EPDIFF2 DFHMDF POS=(3,54),LENGTH=16,INITIAL='Monthly Payment', * | ||
ATTRB=(PROT,NORM) | ||
LITPHN1 DFHMDF POS=(3,71),LENGTH=7,INITIAL='# Years', * | ||
ATTRB=(PROT,NORM) | ||
EPCMP1 DFHMDF POS=(4,1),LENGTH=24, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPPHN1 DFHMDF POS=(4,26),LENGTH=13, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPRATE1 DFHMDF POS=(4,45),LENGTH=5, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPLOAN1 DFHMDF POS=(4,56),LENGTH=12, * | ||
ATTRB=(NUM,IC,NORM) | ||
EPYEARS1 DFHMDF POS=(4,74),LENGTH=2, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPCMP2 DFHMDF POS=(5,1),LENGTH=24, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPPHN2 DFHMDF POS=(5,26),LENGTH=13, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPRATE2 DFHMDF POS=(5,45),LENGTH=5, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPLOAN2 DFHMDF POS=(5,56),LENGTH=12, * | ||
ATTRB=(NUM,IC,NORM) | ||
EPYEARS2 DFHMDF POS=(5,74),LENGTH=2, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPCMP3 DFHMDF POS=(6,1),LENGTH=24, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPPHN3 DFHMDF POS=(6,26),LENGTH=13, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPRATE3 DFHMDF POS=(6,45),LENGTH=5, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPLOAN3 DFHMDF POS=(6,56),LENGTH=12, * | ||
ATTRB=(NUM,IC,NORM) | ||
EPYEARS3 DFHMDF POS=(6,74),LENGTH=2, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPCMP4 DFHMDF POS=(7,1),LENGTH=24, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPPHN4 DFHMDF POS=(7,26),LENGTH=13, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPRATE4 DFHMDF POS=(7,45),LENGTH=5, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPLOAN4 DFHMDF POS=(7,56),LENGTH=12, * | ||
ATTRB=(NUM,IC,NORM) | ||
EPYEARS4 DFHMDF POS=(7,74),LENGTH=2, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPCMP5 DFHMDF POS=(8,1),LENGTH=24, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPPHN5 DFHMDF POS=(8,26),LENGTH=13, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPRATE5 DFHMDF POS=(8,45),LENGTH=5, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPLOAN5 DFHMDF POS=(8,56),LENGTH=12, * | ||
ATTRB=(NUM,IC,NORM) | ||
EPYEARS5 DFHMDF POS=(8,74),LENGTH=2, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPCMP6 DFHMDF POS=(9,1),LENGTH=24, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPPHN6 DFHMDF POS=(9,26),LENGTH=13, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPRATE6 DFHMDF POS=(9,45),LENGTH=5, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPLOAN6 DFHMDF POS=(9,56),LENGTH=12, * | ||
ATTRB=(NUM,IC,NORM) | ||
EPYEARS6 DFHMDF POS=(9,74),LENGTH=2, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPCMP7 DFHMDF POS=(10,1),LENGTH=24, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPPHN7 DFHMDF POS=(10,26),LENGTH=13, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPRATE7 DFHMDF POS=(10,45),LENGTH=5, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPLOAN7 DFHMDF POS=(10,56),LENGTH=12, * | ||
ATTRB=(NUM,IC,NORM) | ||
EPYEARS7 DFHMDF POS=(10,74),LENGTH=2, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPCMP8 DFHMDF POS=(11,1),LENGTH=24, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPPHN8 DFHMDF POS=(11,26),LENGTH=13, * | ||
ATTRB=(PROT,NORM),HILIGHT=OFF,COLOR=GREEN | ||
EPRATE8 DFHMDF POS=(11,45),LENGTH=5, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
EPLOAN8 DFHMDF POS=(11,56),LENGTH=12, * | ||
ATTRB=(NUM,IC,NORM) | ||
DFHMDF POS=(11,69), * | ||
ATTRB=ASKIP | ||
EPYEARS8 DFHMDF POS=(11,74),LENGTH=2, * | ||
ATTRB=(NUM,NORM),COLOR=GREEN | ||
DFHMDF POS=(11,77),LENGTH=0, * | ||
ATTRB=ASKIP | ||
DFHMDF POS=(23,17),LENGTH=43, * | ||
INITIAL='Press F3 to quit or Enter to calculate loan', * | ||
ATTRB=(ASKIP,NORM),HILIGHT=OFF,COLOR=BLUE | ||
MSGERR DFHMDF POS=(24,17),LENGTH=40,INITIAL='INVALID KEY PRESSED', X | ||
ATTRB=(PROT,DRK) | ||
EPSMLIS DFHMSD TYPE=FINAL | ||
END |
2 changes: 2 additions & 0 deletions
2
test/applications/MortgageApplication/build-conf/mergeBuildOpts.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# mainBuildBranch requires to be overriden for the mergeBuild test scenario | ||
# mainBuildBranch=${props.branch} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
CBL NUMPROC(MIG),FLAG(I,W),RENT | ||
ID DIVISION. | ||
PROGRAM-ID. EPSCSMRT. | ||
* THIS IS A CALLED PROGRAM EXAMPLE FOR DEMONSTRATION | ||
* | ||
* THIS PROGRAM IS INVOKED VIA A CICS LINK STATMENT | ||
* AND DYNAMICALLY CALLS THE ACTUAL PROGRAM | ||
* | ||
* TEST CHANGE | ||
* | ||
* (C) 2017 IBM JIM HILDNER. | ||
ENVIRONMENT DIVISION. | ||
CONFIGURATION SECTION. | ||
SOURCE-COMPUTER. FLEX-ES. | ||
OBJECT-COMPUTER. FLEX-ES. | ||
DATA DIVISION. | ||
WORKING-STORAGE SECTION. | ||
* | ||
01 WS-CALLED-PROGRAM PIC X(8). | ||
|
||
01 STATIC-CALLED-PROGRAMS. | ||
03 STATIC-CALLED-PROGRAM-TABLE. | ||
05 FILLER PIC X(8) VALUE 'EPSMPMT'. | ||
05 FILLER PIC X(8) VALUE 'NOT VLD'. | ||
05 FILLER PIC X(8) VALUE ' '. | ||
03 CALLED-PROGRAM-TABLE | ||
REDEFINES STATIC-CALLED-PROGRAM-TABLE | ||
OCCURS 3 TIMES. | ||
05 CALLED-PROGRAM-NAME PIC X(8). | ||
|
||
COPY EPSPDATA. | ||
|
||
LINKAGE SECTION. | ||
* | ||
01 DFHCOMMAREA. | ||
COPY EPSMTCOM. | ||
|
||
PROCEDURE DIVISION USING DFHCOMMAREA. | ||
* | ||
A000-MAINLINE. | ||
MOVE EPSPCOM-PRINCIPLE-DATA TO EPSPDATA-PRINCIPLE-DATA. | ||
MOVE EPSPCOM-NUMBER-OF-YEARS TO EPSPDATA-NUMBER-OF-YEARS. | ||
MOVE 'Y' TO EPSPDATA-YEAR-MONTH-IND. | ||
MOVE EPSPCOM-QUOTED-INTEREST-RATE | ||
TO | ||
EPSPDATA-QUOTED-INTEREST-RATE. | ||
MOVE CALLED-PROGRAM-NAME(1) TO WS-CALLED-PROGRAM. | ||
MOVE SPACES TO EPSPDATA-RETURN-ERROR. | ||
* CALL 'EPSMPMT' USING EPSPDATA. | ||
CALL WS-CALLED-PROGRAM USING EPSPDATA. | ||
MOVE EPSPDATA-RETURN-MONTH-PAYMENT | ||
TO | ||
EPSPCOM-RETURN-MONTH-PAYMENT. | ||
MOVE EPSPDATA-RETURN-ERROR TO EPSPCOM-ERRMSG. | ||
IF EPSPDATA-RETURN-ERROR = SPACES | ||
MOVE ZERO TO EPSPCOM-PROGRAM-RETCODE | ||
ELSE | ||
MOVE 8 TO EPSPCOM-PROGRAM-RETCODE | ||
END-IF. | ||
GOBACK | ||
. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are changing the current behavior here. Any reason to force providing a repository connection in case of a full build?
I very often perform a full build without repository connection just to test that my whole application can compile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting use case, I have not thought about this case so far. Always interesting to see the different usages.
Doesn't your use cause an issue when zAppBuild would like to update the collection? See line 517 in build.groovy
I felt it was a missing test for the fullBuild actually . Happy to revert this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this is behavior that @drbruce-git has intentionally implemented in its design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reverted it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had always assumed that full build required a repository client so that it can store collections and build results for subsequent incremental builds.