Set a Binding's owner reference, but not a controller reference #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Starich <[email protected]>
Signed-off-by: John Starich <[email protected]>
Signed-off-by: John Starich <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 92.07% 92.32% +0.25%
==========================================
Files 6 6
Lines 757 821 +64
==========================================
+ Hits 697 758 +61
- Misses 39 41 +2
- Partials 21 22 +1
Continue to review full report at Codecov.
|
Signed-off-by: John Starich <[email protected]>
DevTroyer
reviewed
Aug 5, 2021
| @@ -76,10 +76,11 @@ type BindingReconciler struct { | |||
| GetCFServiceKeyCredentials cfservice.KeyGetter | |||
| GetServiceName resource.ServiceNameGetter | |||
| GetServiceRoleCRN iam.ServiceRolesGetter | |||
| SetControllerReference ControllerReferenceSetter | |||
| SetControllerReference OwnerReferenceSetter | |||
There was a problem hiding this comment.
Is this still needed here?
There was a problem hiding this comment.
Yep! We still have controller references set on the Binding's generated secrets 👍
DevTroyer
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bindings currently have owner references set to their Service counterpart. However, they use
controller: truetoday – which causes problems when orchestrated by other operators.Bindings don't need
controller: truesince they weren't created by the operator, they were created by some other entity (e.g. CrossPlane operator or manually).The controller owner reference really only belongs on Secrets it creates for a Binding object, since those are entirely managed by the controller. Further reading: Owners and dependents, ControllerRef proposal
To preserve backward compatibility, the owner reference remains but is no longer set as a "controller reference."
Fixes #222, fixes #254
Closes #255