Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable shellcheck #231

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Enable shellcheck #231

merged 3 commits into from
Nov 17, 2020

Conversation

JohnStarich
Copy link
Member

Adds shellcheck linter for checked in shell scripts and fixes issues.

Signed-off-by: John Starich <[email protected]>
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #231 (b84eed8) into master (91ecd0b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #231   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files           6        6           
  Lines         756      756           
=======================================
  Hits          696      696           
  Misses         39       39           
  Partials       21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91ecd0b...b84eed8. Read the comment docs.

Copy link
Member

@jmulsow jmulsow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JohnStarich JohnStarich merged commit 6a5bfab into master Nov 17, 2020
@JohnStarich JohnStarich deleted the feature/shellcheck branch November 17, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants