Add tests to ensure an alias service will never issue an API call to create #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…create Signed-off-by: John Starich <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
=======================================
Coverage 91.11% 91.11%
=======================================
Files 6 6
Lines 754 754
=======================================
Hits 687 687
Misses 44 44
Partials 23 23 Continue to review full report at Codecov.
|
artberger
pushed a commit
that referenced
this pull request
Sep 23, 2020
…create (#211) Signed-off-by: John Starich <[email protected]> Signed-off-by: Art Berger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71
I was unable to find a possible path where an alias Service could be re-created. Nevertheless, I went through and added additional tests to double-down on that.