Fix default namespace fallback #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Starich <[email protected]>
Signed-off-by: John Starich <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
=======================================
Coverage 91.05% 91.05%
=======================================
Files 6 6
Lines 749 749
=======================================
Hits 682 682
Misses 44 44
Partials 23 23 Continue to review full report at Codecov.
|
Signed-off-by: John Starich <[email protected]>
Signed-off-by: John Starich <[email protected]>
artberger
pushed a commit
that referenced
this pull request
Sep 23, 2020
* Add more logging * Fix bug: was calling wrong IsNotFound func * Remove confusing IsNotFound func from ibmcloud package Signed-off-by: Art Berger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207
Basic fix was to call the correct
.IsNotFoundfunc: