Set up both tests and main.go in one place + add tests to check missing deps #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng deps Signed-off-by: John Starich <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 91.33% 91.05% -0.29%
==========================================
Files 5 6 +1
Lines 704 749 +45
==========================================
+ Hits 643 682 +39
- Misses 41 44 +3
- Partials 20 23 +3
Continue to review full report at Codecov.
|
artberger
pushed a commit
that referenced
this pull request
Sep 23, 2020
…ng deps (#208) Signed-off-by: Art Berger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes missing deps in some controllers that caused panics. Adds a test to ensure this can't happen again