Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OLM data & formatting issues #200

Merged
merged 16 commits into from
Sep 18, 2020
Merged

Fix OLM data & formatting issues #200

merged 16 commits into from
Sep 18, 2020

Conversation

JohnStarich
Copy link
Member

@JohnStarich JohnStarich commented Sep 18, 2020

Fixes OLM metadata so it will install properly from Operator Hub for v0.2+. Adds make tasks to assists OLM testing.
Bumps the memory limit to mitigate an OOMKilled issue when running in OpenShift 4.4 (i.e. lots of built-in secrets). Opened #199 to look into it further.

Also update TokenController to skip processing any secret not using the well-known names. e.g. secret-ibm-cloud-operator <namespace>-secret-ibm-cloud-operator

Signed-off-by: John Starich <[email protected]>
Signed-off-by: John Starich <[email protected]>
Signed-off-by: John Starich <[email protected]>
Signed-off-by: John Starich <[email protected]>
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #200 into master will decrease coverage by 0.47%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   91.80%   91.33%   -0.48%     
==========================================
  Files           5        5              
  Lines         757      704      -53     
==========================================
- Hits          695      643      -52     
  Misses         41       41              
+ Partials       21       20       -1     
Impacted Files Coverage Δ
controllers/token_controller.go 98.11% <83.33%> (-1.89%) ⬇️
controllers/configmap.go 82.35% <0.00%> (-1.86%) ⬇️
controllers/secret.go 88.00% <0.00%> (-1.29%) ⬇️
controllers/binding_controller.go 86.98% <0.00%> (-0.45%) ⬇️
controllers/service_controller.go 96.30% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6bd95...f4dce36. Read the comment docs.

@JohnStarich JohnStarich merged commit dff8b02 into master Sep 18, 2020
@JohnStarich JohnStarich deleted the bugfix/olm-fixes branch September 18, 2020 05:04
artberger pushed a commit that referenced this pull request Sep 23, 2020
Fixes OLM metadata so it will install properly from Operator Hub for v0.2+. Adds make tasks to assists OLM testing.
Bumps the memory limit to mitigate an OOMKilled issue when running in OpenShift 4.4 (i.e. lots of built-in secrets). Opened #199 to look into it further.

Also update TokenController to skip processing any secret not using the well-known names. e.g. `secret-ibm-cloud-operator` `<namespace>-secret-ibm-cloud-operator`

Signed-off-by: Art Berger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant