Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc edits for the contributors guide #193

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Doc edits for the contributors guide #193

merged 2 commits into from
Sep 14, 2020

Conversation

artberger
Copy link
Contributor

Part of a general doc sweep of existing content.

  • Revised contributor guide for grammar, IBM Style
  • Updated TOC
  • Added documentation contribution guides

Signed-off-by: Art Berger [email protected]

Art Berger added 2 commits September 9, 2020 17:34
@artberger artberger added the docs label Sep 10, 2020
@artberger artberger self-assigned this Sep 10, 2020
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #193 into master will decrease coverage by 0.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
- Coverage   75.79%   75.13%   -0.67%     
==========================================
  Files           5        5              
  Lines         756      756              
==========================================
- Hits          573      568       -5     
- Misses        135      139       +4     
- Partials       48       49       +1     
Impacted Files Coverage Δ
controllers/service_controller.go 55.13% <0.00%> (-1.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db01a6...2f89913. Read the comment docs.

Copy link
Member

@JohnStarich JohnStarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

I think some of the existing guidelines are out of date, but we can update those later 👍

@JohnStarich JohnStarich merged commit 0bbeab5 into master Sep 14, 2020
@JohnStarich JohnStarich deleted the adb-doc-review branch September 14, 2020 19:38
artberger added a commit that referenced this pull request Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants