Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binding controller unit tests #190

Merged
merged 22 commits into from
Sep 2, 2020
Merged

Add binding controller unit tests #190

merged 22 commits into from
Sep 2, 2020

Conversation

JohnStarich
Copy link
Member

@JohnStarich JohnStarich commented Sep 1, 2020 •
edited
Loading

Closes #171

@JohnStarich
Add token controller failed auth test
c1d29f6 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Enable fast unit test feedback with '-short' test flag
3cd6f65 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Add token controller unit tests
1410c94 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Add mock k8s client, add initial binding tests
347c7dc 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Extract more deps, add more tests
df1fc40 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Run binding tests in parallel
68a0e41 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Add -race to make test, fix race getting controller namespace
26d540c 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Add more tests
394e2f9 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Add more tests
c86f994 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Add more tests
20a9be9 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Merge branch 'master' into feature/binding-controller-tests
e9bf237
@JohnStarich
Add more tests
c26eb92 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Try removing -race test flag
f17e1e5 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Add -race flag back, try with -short
b9a15d0 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Bump testify to fix race condition in assert.Eventually
3327e52 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Fix go.sum
686cb87 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Explicitly set metav1.Now() time zone for Travis CI
0a1d3a3 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Fix metav1.Now() not being equal to itself
0855a77 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Remove -short test flag
2d8d567 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
Move mock client to _test.go suffix
9ff6fdf 
Signed-off-by: John Starich <[email protected]>
@IBM IBM deleted a comment from codecov bot Sep 1, 2020
@codecov
Copy link

codecov bot commented Sep 1, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@25652ce). Click here to learn what that means.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #190   +/-   ##
=========================================
  Coverage          ?   75.79%           
=========================================
  Files             ?        5           
  Lines             ?      756           
  Branches          ?        0           
=========================================
  Hits              ?      573           
  Misses            ?      135           
  Partials          ?       48
Impacted Files Coverage Δ
controllers/binding_controller.go 86.88% <80.95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25652ce...ff4b8b9. Read the comment docs.

@JohnStarich JohnStarich marked this pull request as ready for review September 1, 2020 19:40
@JohnStarich
Fix token controller time.now
4cfbd91 
Signed-off-by: John Starich <[email protected]>
@JohnStarich
More parallel
ff4b8b9 
Signed-off-by: John Starich <[email protected]>
@JohnStarich JohnStarich merged commit 2b9afb2 into master Sep 2, 2020
@JohnStarich JohnStarich deleted the feature/binding-controller-tests branch September 2, 2020 01:03
@JohnStarich JohnStarich mentioned this pull request Sep 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase binding controller test coverage to 85%
1 participant
@JohnStarich