Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install docs #185

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Update install docs #185

merged 1 commit into from
Aug 26, 2020

Conversation

JohnStarich
Copy link
Member

No description provided.

Signed-off-by: John Starich <[email protected]>
Copy link
Member

@vazirim vazirim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #185 into master will increase coverage by 0.17%.
The diff coverage is 41.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   41.46%   41.63%   +0.17%     
==========================================
  Files          13        5       -8     
  Lines        1423      879     -544     
==========================================
- Hits          590      366     -224     
+ Misses        714      423     -291     
+ Partials      119       90      -29     
Impacted Files Coverage Δ
controllers/configmap.go 0.00% <0.00%> (ø)
controllers/secret.go 17.85% <17.85%> (ø)
controllers/binding_controller.go 36.47% <36.47%> (ø)
controllers/service_controller.go 46.70% <46.70%> (ø)
controllers/token_controller.go 74.13% <74.13%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87768a0...6d1a7c2. Read the comment docs.

@JohnStarich JohnStarich merged commit 6534625 into master Aug 26, 2020
@JohnStarich JohnStarich deleted the build/install-instructions branch August 26, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants