Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default configure action to store-creds, use intuitive names for install and remove #183

Merged
merged 3 commits into from
Aug 26, 2020

Conversation

JohnStarich
Copy link
Member

Also adds validation for required fields, like region and resourcegroup to fix #72

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #183 into master will increase coverage by 1.76%.
The diff coverage is 43.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   41.46%   43.23%   +1.76%     
==========================================
  Files          13        5       -8     
  Lines        1423      879     -544     
==========================================
- Hits          590      380     -210     
+ Misses        714      410     -304     
+ Partials      119       89      -30     
Impacted Files Coverage Δ
controllers/configmap.go 0.00% <0.00%> (ø)
controllers/secret.go 17.85% <17.85%> (ø)
controllers/binding_controller.go 36.47% <36.47%> (ø)
controllers/service_controller.go 50.71% <50.71%> (ø)
controllers/token_controller.go 74.13% <74.13%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3cedbb...4fe5992. Read the comment docs.

Copy link
Member

@vazirim vazirim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnStarich JohnStarich merged commit 87768a0 into master Aug 26, 2020
@JohnStarich JohnStarich deleted the feature/simpler-scripts branch August 26, 2020 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

account information checks from config-operator.sh
2 participants