Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenShift-specific section to the README, & spruce up docs #182

Merged
merged 4 commits into from
Aug 25, 2020

Conversation

JohnStarich
Copy link
Member

@JohnStarich JohnStarich commented Aug 25, 2020

Here's what the preview looks like for operator hub:

operator-hub-preview-0 2 1

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #182 into master will increase coverage by 0.97%.
The diff coverage is 42.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   41.46%   42.43%   +0.97%     
==========================================
  Files          13        5       -8     
  Lines        1423      879     -544     
==========================================
- Hits          590      373     -217     
+ Misses        714      417     -297     
+ Partials      119       89      -30     
Impacted Files Coverage Δ
controllers/configmap.go 0.00% <0.00%> (ø)
controllers/secret.go 17.85% <17.85%> (ø)
controllers/binding_controller.go 36.47% <36.47%> (ø)
controllers/service_controller.go 48.71% <48.71%> (ø)
controllers/token_controller.go 74.13% <74.13%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d280bfe...1b1b97e. Read the comment docs.

Copy link
Member

@vazirim vazirim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnStarich JohnStarich merged commit d3cedbb into master Aug 25, 2020
@JohnStarich JohnStarich deleted the feature/openshift branch August 25, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants