Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always store credentials when running configure, even if they exist #181

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

JohnStarich
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #181 into master will increase coverage by 2.90%.
The diff coverage is 44.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   41.46%   44.36%   +2.90%     
==========================================
  Files          13        5       -8     
  Lines        1423      879     -544     
==========================================
- Hits          590      390     -200     
+ Misses        714      401     -313     
+ Partials      119       88      -31     
Impacted Files Coverage Δ
controllers/configmap.go 0.00% <0.00%> (ø)
controllers/secret.go 25.00% <25.00%> (ø)
controllers/binding_controller.go 38.58% <38.58%> (ø)
controllers/service_controller.go 50.42% <50.42%> (ø)
controllers/token_controller.go 74.13% <74.13%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5581f89...3612db4. Read the comment docs.

@JohnStarich JohnStarich merged commit d280bfe into master Aug 25, 2020
@JohnStarich JohnStarich deleted the bugfix/always-store-creds branch August 25, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants