doc updates per cert issue #142
Conversation
Signed-off-by: Vera <[email protected]>
There was a problem hiding this comment.
Could we use TLS or SSL/TLS instead of SSL throughout (the chances of anyone still permitting SSL being very low!)?
Also I think I'd like to see the legit solution before the workaround or at least a 'not recommended' or 'be sure you know what you're doing' attached to it.
Signed-off-by: Vera <[email protected]>
|
Hi Ben, I've addressed your comments in commit b073ad7. The position of the two solutions are swithed and a Recommended tag is added to the legit way. There was a note warning against the security consequences of the other way but it was a bit obscure, so I highlighted it with a note in a separate paragraph. Let me know if any concerns? |
Signed-off-by: Ben Cox <[email protected]>
There was a problem hiding this comment.
Looks good to me - I spotted that the README numbering wasn't continuing inside Troubleshooting (1. ...then 1.) so pushed a fix that changed that, plus changed a couple of mentions of 'JVM server' to 'JVM' as this is a change on the client side, so probably just a plain ol' JVM.
I'm approving, so if you're happy with my change then feel free to merge.
|
Hi Vera, changes look good. I would suggest in the pom.xml, in the comment above the option add another line to say this is not recommended and read the readme trouble shooting section for more details. |
Signed-off-by: Vera [email protected]