Fix OSGi Bundle deploy by setting symbolicName from manifest #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-foyle
force-pushed
the
osgi
branch
7 times, most recently
from
5345070 to
37e1357
Compare
|
Have you been able to verify this against the deployment endpoint (or otherwise got it installed into CICS)? If it works then perhaps let's release |
Haven't quite got it working yet. Getting there though... |
tom-foyle
force-pushed
the
osgi
branch
3 times, most recently
from
262ab37 to
30aec94
Compare
Apply OSGi changes from cics-bundle-common 0.0.3. Name moved higher in binding hierarchy. It took me a while to figure out what was going on with the two Artifact classes, so I tried to make it clearer. test-no-transitive converted to war just so I didn't have to bother with a manifest file. Signed-off-by: Tom Foyle <[email protected]>
davenice
previously approved these changes
Feb 24, 2020
Signed-off-by: Tom Foyle <[email protected]>
davenice
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply OSGi changes from cics-bundle-common 0.0.3. It took me a while to figure out what was going on with the two Artifact classes, so I tried to make it clearer. Changed test-no-transitive to use war instead of jar for simplicity.
Signed-off-by: Tom Foyle [email protected]