-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal traps keydown event for esc
key for the whole document
#2312
Comments
asudoh
added a commit
to asudoh/carbon-components
that referenced
this issue
Apr 16, 2019
asudoh
added a commit
that referenced
this issue
Apr 17, 2019
@asudoh Can you port this change to v9? I think we still have a long way to move to v10. |
asudoh
added a commit
to asudoh/carbon-components
that referenced
this issue
Apr 23, 2019
asudoh
added a commit
that referenced
this issue
Apr 24, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Detailed description
Other elements are not able to add keydown event for the escape key
The keydown event should not add to the document level and stop it from propagating
Steps to reproduce the issue
Add a event listener for the escape keydown event to any element in the document, and it's not response to the escape key
Additional information
the line of code doing that
https://github.com/IBM/carbon-components/blob/master/src/components/modal/modal.js#L139
The text was updated successfully, but these errors were encountered: