Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ping test #32

Merged
merged 1 commit into from
Jun 10, 2024
Merged

bugfix: ping test #32

merged 1 commit into from
Jun 10, 2024

Conversation

cmisale
Copy link
Collaborator

@cmisale cmisale commented Jun 7, 2024

This PR fixes two bugs in the ping test

  1. The ABORT message wasn't being parsed, and the test would report success with consequent success export to Prometheus
  2. The count of the interfaces done to check if there were issues with multi-nic assigning the secondary interfaces, wasn't taking into account that having eth0 only is a valid deployment of the daemonset

@cmisale cmisale requested review from jimcadden, eletonia and lasch June 7, 2024 19:32
@cmisale cmisale self-assigned this Jun 7, 2024
Copy link
Collaborator

@jimcadden jimcadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmisale cmisale merged commit 5a19da8 into main Jun 10, 2024
4 checks passed
@cmisale cmisale deleted the ping-patch branch June 10, 2024 17:17
eletonia pushed a commit to eletonia/autopilot that referenced this pull request Aug 13, 2024
bugfix in running ping on a subset of nodes. Plus some code restyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants