-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update partnercentersell service #5721
Conversation
Signed-off-by: Balázs Marján <[email protected]>
Signed-off-by: Balázs Marján <[email protected]>
Signed-off-by: Peter Harasztia <[email protected]>
…r/terraform-provider-ibm into update-partnercentersellv1
Signed-off-by: Peter Harasztia <[email protected]>
… gitignore extended with .env Signed-off-by: Peter Harasztia <[email protected]>
Signed-off-by: Peter Harasztia <[email protected]>
Signed-off-by: Peter Harasztia <[email protected]>
Signed-off-by: Peter Harasztia <[email protected]>
Signed-off-by: Peter Harasztia <[email protected]>
Signed-off-by: Peter Harasztia <[email protected]>
Signed-off-by: Peter Harasztia <[email protected]>
Signed-off-by: Peter Harasztia <[email protected]>
Signed-off-by: Peter Harasztia <[email protected]>
Update partnercentersellv1
Signed-off-by: Peter Harasztia <[email protected]>
Signed-off-by: Peter Harasztia <[email protected]>
Signed-off-by: Peter Harasztia <[email protected]>
Signed-off-by: Peter Harasztia <[email protected]>
…r/terraform-provider-ibm into update-partnercentersellv1
Signed-off-by: Peter Harasztia <[email protected]>
Update partnercentersellv1
Signed-off-by: Peter Harasztia <[email protected]>
=== RUN TestAccIbmOnboardingResourceBrokerBasic === RUN TestAccIbmOnboardingRegistrationBasic === RUN TestAccIbmOnboardingProductBasic === RUN TestAccIbmOnboardingCatalogDeploymentBasic --- PASS: TestAccIbmOnboardingCatalogPlanBasic (74.81s) === RUN TestAccIbmOnboardingCatalogProductBasic |
ibm/service/partnercentersell/resource_ibm_onboarding_resource_broker.go
Outdated
Show resolved
Hide resolved
ibm/service/partnercentersell/resource_ibm_onboarding_resource_broker.go
Outdated
Show resolved
Hide resolved
ibm/service/partnercentersell/resource_ibm_onboarding_iam_registration.go
Outdated
Show resolved
Hide resolved
ibm/service/partnercentersell/resource_ibm_onboarding_iam_registration.go
Outdated
Show resolved
Hide resolved
ibm/service/partnercentersell/resource_ibm_onboarding_catalog_deployment.go
Outdated
Show resolved
Hide resolved
ibm/service/partnercentersell/resource_ibm_onboarding_catalog_plan.go
Outdated
Show resolved
Hide resolved
ibm/service/partnercentersell/resource_ibm_onboarding_catalog_product.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Peter Harasztia <[email protected]>
Signed-off-by: Peter Harasztia <[email protected]>
Signed-off-by: Peter Harasztia <[email protected]>
@@ -46,7 +46,7 @@ func ResourceIbmOnboardingIamRegistration() *schema.Resource { | |||
}, | |||
"name": &schema.Schema{ | |||
Type: schema.TypeString, | |||
Optional: true, | |||
Required: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing from Optional to Required are kind of breaking changes for user's . IF its required share me notes section which I can included in release notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of our documents contains the following notice:
Note - Intended for internal use only. This resource is strictly experimental and subject to change without notice.
Remaining looks fine |
Community Note
Relates OR Closes #0000
Output from acceptance testing: