Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GRS arguments for pi_instance boot volume replication #5665

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add GRS arguments for pi_instance boot volume replication #5665

merged 1 commit into from
Oct 11, 2024

Conversation

Alexander-Kita
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMPIInstanceDeploymentGRS
--- PASS: TestAccIBMPIInstanceDeploymentGRS (1164.25s)
PASS

Description:

  • Added argument pi_boot_volume_replication_enabled (Boolean) which specifies whether the boot volume will be replication enabled
  • Added argument pi_replication_sites (List) which specifies replication sites for boot volume replication. Argument above must be true to use this.
  • Add GRS test to see if created boot volume replication and site is set correctly

@Alexander-Kita Alexander-Kita added the service/Power Systems Issues related to Power Systems label Sep 23, 2024
@Alexander-Kita
Copy link
Collaborator Author

@hkantare @yussufsh Please review as part of power Q3 release.

ismirlia
ismirlia previously approved these changes Sep 23, 2024
View reviewed changes
michaelkad
michaelkad previously approved these changes Oct 1, 2024
View reviewed changes
yussufsh
yussufsh previously approved these changes Oct 11, 2024
View reviewed changes
@yussufsh
Copy link
Collaborator

@Alexander-Kita please help with rebase.

yussufsh
yussufsh previously approved these changes Oct 11, 2024
View reviewed changes
@yussufsh yussufsh self-requested a review October 11, 2024 16:02
@yussufsh
Copy link
Collaborator

@Alexander-Kita please check the failures.

@Alexander-Kita
Copy link
Collaborator Author

@yussufsh resolved

@yussufsh yussufsh merged commit bba26b8 into master Oct 11, 2024
1 check passed
@Alexander-Kita Alexander-Kita deleted the add-gsr-attributes-instance-r branch November 19, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@michaelkad michaelkad michaelkad left review comments

@hkantare hkantare Awaiting requested review from hkantare

@ismirlia ismirlia Awaiting requested review from ismirlia

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alexander-Kita @yussufsh @michaelkad @ismirlia