-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Granular CRN for instance datasources and resources #5647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexander-Kita
requested review from
yussufsh,
hkantare,
michaelkad and
ismirlia
September 17, 2024 19:34
ismirlia
previously approved these changes
Sep 18, 2024
Alexander-Kita
force-pushed
the
crn-instance
branch
from
September 20, 2024 16:34
df29bc5
to
c409ad1
Compare
ismirlia
previously approved these changes
Sep 20, 2024
Alexander-Kita
force-pushed
the
crn-instance
branch
from
September 23, 2024 16:20
c409ad1
to
98b4054
Compare
ismirlia
approved these changes
Sep 23, 2024
ismirlia
previously approved these changes
Sep 23, 2024
Alexander-Kita
force-pushed
the
crn-instance
branch
from
September 27, 2024 16:38
85c96ad
to
0299ee0
Compare
ismirlia
previously approved these changes
Sep 27, 2024
Alexander-Kita
force-pushed
the
crn-instance
branch
from
October 1, 2024 17:08
759ad33
to
099366b
Compare
michaelkad
previously approved these changes
Oct 1, 2024
michaelkad
previously approved these changes
Oct 1, 2024
Alexander-Kita
force-pushed
the
crn-instance
branch
from
October 4, 2024 19:26
f5db9f3
to
b0918c4
Compare
michaelkad
approved these changes
Oct 7, 2024
VaishnaviGopal
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you squash the commits?
Alexander-Kita
force-pushed
the
crn-instance
branch
from
October 10, 2024 14:03
b0918c4
to
4f5e2e9
Compare
@VaishnaviGopal done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing:
pi_instance (r):
pi_cloud_instance (d):
pi_instance (d):
pi_instances (d):
pi_capture (r):