Granular CRN for image datasources and resources

[Alexander-Kita]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_catalog_images (d):

=== RUN   TestAccIBMPICatalogImagesDataSourceBasic
--- PASS: TestAccIBMPICatalogImagesDataSourceBasic (52.36s)
PASS

=== RUN   TestAccIBMPICatalogImagesDataSourceVTL
--- PASS: TestAccIBMPICatalogImagesDataSourceVTL (51.41s)
PASS

=== RUN   TestAccIBMPICatalogImagesDataSourceSAP
--- PASS: TestAccIBMPICatalogImagesDataSourceSAP (74.17s)
PASS

=== RUN   TestAccIBMPICatalogImagesDataSourceSAPAndVTL
--- PASS: TestAccIBMPICatalogImagesDataSourceSAPAndVTL (61.02s)
PASS

pi_image (d):

=== RUN   TestAccIBMPIImageDataSource_basic
--- PASS: TestAccIBMPIImageDataSource_basic (17.08s)
PASS

pi_images (d):

=== RUN   TestAccIBMPIImagesDataSource_basic
--- PASS: TestAccIBMPIImagesDataSource_basic (28.87s)
PASS

pi_image (r):

=== RUN   TestAccIBMPIImagebasic
--- PASS: TestAccIBMPIImagebasic (40.15s)
PASS

(Used private bucket)

=== RUN   TestAccIBMPIImageCOSPublicImport
--- PASS: TestAccIBMPIImageCOSPublicImport (1227.62s)
PASS

=== RUN   TestAccIBMPIImageBYOLImport
--- PASS: TestAccIBMPIImageBYOLImport (1817.78s)
PASS

--- PASS: TestAccIBMPIImageUserTags (38.51s)
PASS

[Alexander-Kita]

@yussufsh, @hkantare Can you please review this PR which part of power Q3

[hkantare]

change in tags shouldn't be force_new. Either suppress the diff or provide update support

[ismirlia]

User tags cannot be updated. Why is this incorrect? We don't want users to try to update the user tag field thinking it will do something.

[michaelkad]

@hkantare Since are only supporting this at creation, forceNew is okay here. The management of the userTags will be handle by Global Tagging at this moment. Like @ismirlia said we won't be allowing the user to update this.

[hkantare]

@michaelkad Why can't we adapt the same approach like other services team
During create/update always use Global Tagging API's.
This gives capability for user's to add /update tags

[michaelkad]

@hkantare We will make a change to let the user update the tags using the Global Tagging API's.

[hkantare]

Change the Type to schema.TypeSet to handle the unordered collection. List is ordered collection even if their change in the position of tags it will show diff

"tags": {
				Type:        schema.TypeSet,
				Optional:    true,
				Elem:        &schema.Schema{Type: schema.TypeString},
				Set:         schema.HashString,
				Description: "Tags set for the resource",
			},
			```

[michaelkad]

@hkantare we have updated the pr