-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Code Engine functions #5596
Conversation
hasChange := false | ||
|
||
patchVals := &codeenginev2.FunctionPatch{} | ||
if d.HasChange("project_id") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this block is n't required when you mark ForceNew : true on "project_id" argument
Description: "The name of the function.", | ||
}, | ||
"run_env_variables": { | ||
Type: schema.TypeList, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use TypeSet .
With TypeList when the order changes in user tf and in state file it always show a diff when more than one element is provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything else that would change when switching from TypeList
to TypeSet
or are they mostly interchangeable?
value = "value" | ||
} | ||
|
||
lifecycle { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block is n't required when we use TypeSet.
Adding this block restricts user's to do update of run_env_variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you very much for reviewing our PR. I have a question from our side though. We ignore changes here, because our system injects some run_env_variables
on the server-side, resulting in diffs during testing and obviously from the user's perspective. Users can react by adding those system-generated variables to the definition alongside the user-defined ones.
Are you saying that if we changed it to TypeSet
, Terraform would be able to identify changes in the user-set variables only and ignore outside changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No TypeSet doesn't identify the changes . Can we loop , identify system-generated variables before setting back in read method?
Typeset is unordered list so it will help in controlling diff on the order of items in the list
Resolve confiicts in .secretbaseline file |
9d74cd4
to
0d03a89
Compare
I think we use to have same behavior in deprecated function to filter system-defined parameters/annotation terraform-provider-ibm/ibm/flex/structures.go Line 1269 in 7e9da7b
|
Do you think we can get this in September? We are addressing the environment variable issue in a future PR by introducing a new computed env variable field to hold the system-defined env vars. As I mentioned before, this issue is not at all related to the current PR. So, I see no reason to hold the current PR up. The env var fields in functions are not unique to functions and exist in our existing jobs and applications resources as well. |
* Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check
* Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check
…BM-Cloud#5632) discourage use of ibm_container_bind_service (IBM-Cloud#5588) * discourage use of ibm_container_bind_service Signed-off-by: Bence Vidosits <[email protected]> * fix link --------- Signed-off-by: Bence Vidosits <[email protected]> Co-authored-by: Bence Vidosits <[email protected]> updated resources, data source and documentation for Slack Direct destination support Add test bucket endpoints (IBM-Cloud#5636) * add changes for test bucket endpoints * update code --------- Co-authored-by: Deeksha Sharma <[email protected]> Add support for Code Engine functions (IBM-Cloud#5596) * Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check Fix the 5635 - The ibm_resource_tag now checks the response in the api tags calls (IBM-Cloud#5641) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes * Added new context functions. Now the code handles the error in the response on resource tags calls. * Fixed 5635 * Fix * Fixed * Removed logs line IAM Policy Assignment: S2S Policy Assignments ET and AG (IBM-Cloud#5624) * IAM Policy Assignment: S2S Policy Assignments ET and AG Signed-off-by: Alluri-Varma <[email protected]> * resolving CVE's for EPAP * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG --------- Signed-off-by: Alluri-Varma <[email protected]> Co-authored-by: Alluri-Varma <[email protected]> migrattion of vpc-go-sdk to 0.58.0 (IBM-Cloud#5652) * migration of vpc-go-sdk to 0.58.0 * make fmt changes fix for context and history parameter of template assignment (IBM-Cloud#5640) Signed-off-by: Somanath Chavan <[email protected]> Updating to latest schematics sdk and updating sch_agent resource to enable force deletion by default (IBM-Cloud#5660) * Updated schematics go sdk version to v0.3.0 * Fix issue5475 * Changed the supported tf version for ws creation from 1.4-1.9 add support for 4th zone (IBM-Cloud#5644) Co-authored-by: Ujjwal Kumar <[email protected]> Bump up verison to 1.70.0-beta0 Adding new resource ibm_cos_lifecycle_configuration to manage lifecyc… (IBM-Cloud#5619) * Adding new resource ibm_cos_lifecycle_configuration to manage lifecycle policy for bucket * Adding the data source changes * Data source changes * Adding the import documentation * Addressing the review comments * Updating the resource to use context * Changes to add multiple abort_incomplete_multipart_upload review comments versions change config file changes
…s_tag. Fixed 5566 too. (IBM-Cloud#5567) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes SM New error formatting + crypto_key label name changes (IBM-Cloud#5562) * SC addition * SC addition * SC addition * update function updated * SC unit tests added * SC unit tests added * d * tests fixes * tests fixes * update sdk * .secrets.baseline update * .secrets.baseline update * .secrets.baseline update * Update sm_service_credentials_secret_metadata.html.markdown * bugs fixes * bugs fixes * bugs fixes * docs bugs fixes * preferred_chain added for public cert lets encrypt configuration * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * preferred chain docs update * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * fix public cert bug * update docs * reordering bug in alt_names * name regex fix in docs * imported cert bug fix * crypto_key addition * crypto_key addition * crypto_key addition * crypto_key addition * rejections fixes * rejections fixes * rejections fixes * rejections fixes * rejections fixes * test label name changed * test label name changed * error formating update * go sdk version update --------- Co-authored-by: Yonathan-Yellin <[email protected]> Co-authored-by: Avi Ribchinsky <[email protected]> Co-authored-by: Tatyana <[email protected]> Co-authored-by: Idan Adar <[email protected]> Deprecating alias and bindings APIs and schema items (IBM-Cloud#5612) * Deprecating alias and bindings APIs and schema items Signed-off-by: arshabbir <[email protected]> * Deprecating alias and bindings APIs and schema items --------- Signed-off-by: arshabbir <[email protected]> Add region parameter to logs-routing resources and data sources (IBM-Cloud#5634) * Added region parameter to logs-routing resources and data sources Signed-off-by: Ian Reyes <[email protected]> * Fixed examples for logs-routing resources --------- Signed-off-by: Ian Reyes <[email protected]> Co-authored-by: Ian Reyes <[email protected]> update(cloud-databases): Make Service Endpoints Required and send warning when public endpoints are in use (IBM-Cloud#5402) Added support for reserved ip patch resource (IBM-Cloud#5603) * Added support for ibm_is_subnet_reserved_ip_patch resource * updated the name to optional * Update is_subnet_reserved_ip_patch.html.markdown fix(is_share): added empty check and moved source_share_crn outside (IBM-Cloud#5632) discourage use of ibm_container_bind_service (IBM-Cloud#5588) * discourage use of ibm_container_bind_service Signed-off-by: Bence Vidosits <[email protected]> * fix link --------- Signed-off-by: Bence Vidosits <[email protected]> Co-authored-by: Bence Vidosits <[email protected]> updated resources, data source and documentation for Slack Direct destination support Add test bucket endpoints (IBM-Cloud#5636) * add changes for test bucket endpoints * update code --------- Co-authored-by: Deeksha Sharma <[email protected]> Add support for Code Engine functions (IBM-Cloud#5596) * Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check Fix the 5635 - The ibm_resource_tag now checks the response in the api tags calls (IBM-Cloud#5641) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes --------- ---------
Deprecated ibm_resource_access_tag and replaced it with ibm_iam_access_tag. Fixed 5566 too. (IBM-Cloud#5567) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes SM New error formatting + crypto_key label name changes (IBM-Cloud#5562) * SC addition * SC addition * SC addition * update function updated * SC unit tests added * SC unit tests added * d * tests fixes * tests fixes * update sdk * .secrets.baseline update * .secrets.baseline update * .secrets.baseline update * Update sm_service_credentials_secret_metadata.html.markdown * bugs fixes * bugs fixes * bugs fixes * docs bugs fixes * preferred_chain added for public cert lets encrypt configuration * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * preferred chain docs update * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * fix public cert bug * update docs * reordering bug in alt_names * name regex fix in docs * imported cert bug fix * crypto_key addition * crypto_key addition * crypto_key addition * crypto_key addition * rejections fixes * rejections fixes * rejections fixes * rejections fixes * rejections fixes * test label name changed * test label name changed * error formating update * go sdk version update --------- Co-authored-by: Yonathan-Yellin <[email protected]> Co-authored-by: Avi Ribchinsky <[email protected]> Co-authored-by: Tatyana <[email protected]> Co-authored-by: Idan Adar <[email protected]> Deprecating alias and bindings APIs and schema items (IBM-Cloud#5612) * Deprecating alias and bindings APIs and schema items Signed-off-by: arshabbir <[email protected]> * Deprecating alias and bindings APIs and schema items --------- Signed-off-by: arshabbir <[email protected]> Add region parameter to logs-routing resources and data sources (IBM-Cloud#5634) * Added region parameter to logs-routing resources and data sources Signed-off-by: Ian Reyes <[email protected]> * Fixed examples for logs-routing resources --------- Signed-off-by: Ian Reyes <[email protected]> Co-authored-by: Ian Reyes <[email protected]> update(cloud-databases): Make Service Endpoints Required and send warning when public endpoints are in use (IBM-Cloud#5402) Added support for reserved ip patch resource (IBM-Cloud#5603) * Added support for ibm_is_subnet_reserved_ip_patch resource * updated the name to optional * Update is_subnet_reserved_ip_patch.html.markdown fix(is_share): added empty check and moved source_share_crn outside (IBM-Cloud#5632) discourage use of ibm_container_bind_service (IBM-Cloud#5588) * discourage use of ibm_container_bind_service Signed-off-by: Bence Vidosits <[email protected]> * fix link --------- Signed-off-by: Bence Vidosits <[email protected]> Co-authored-by: Bence Vidosits <[email protected]> updated resources, data source and documentation for Slack Direct destination support Add test bucket endpoints (IBM-Cloud#5636) * add changes for test bucket endpoints * update code --------- Co-authored-by: Deeksha Sharma <[email protected]> Add support for Code Engine functions (IBM-Cloud#5596) * Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check Fix the 5635 - The ibm_resource_tag now checks the response in the api tags calls (IBM-Cloud#5641) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes --------- --------- Deprecating alias and bindings APIs and schema items (IBM-Cloud#5612) --------- IAM Policy Assignment: S2S Policy Assignments ET and AG (IBM-Cloud#5624) * IAM Policy Assignment: S2S Policy Assignments ET and AG Signed-off-by: Alluri-Varma <[email protected]> * resolving CVE's for EPAP * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG --------- Signed-off-by: Alluri-Varma <[email protected]> Co-authored-by: Alluri-Varma <[email protected]> migrattion of vpc-go-sdk to 0.58.0 (IBM-Cloud#5652) * migration of vpc-go-sdk to 0.58.0 * make fmt changes
Deprecated ibm_resource_access_tag and replaced it with ibm_iam_access_tag. Fixed 5566 too. (IBM-Cloud#5567) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes SM New error formatting + crypto_key label name changes (IBM-Cloud#5562) * SC addition * SC addition * SC addition * update function updated * SC unit tests added * SC unit tests added * d * tests fixes * tests fixes * update sdk * .secrets.baseline update * .secrets.baseline update * .secrets.baseline update * Update sm_service_credentials_secret_metadata.html.markdown * bugs fixes * bugs fixes * bugs fixes * docs bugs fixes * preferred_chain added for public cert lets encrypt configuration * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * preferred chain docs update * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * support for creating secret version for username password & version_custom_metadata for all * fix public cert bug * update docs * reordering bug in alt_names * name regex fix in docs * imported cert bug fix * crypto_key addition * crypto_key addition * crypto_key addition * crypto_key addition * rejections fixes * rejections fixes * rejections fixes * rejections fixes * rejections fixes * test label name changed * test label name changed * error formating update * go sdk version update --------- Co-authored-by: Yonathan-Yellin <[email protected]> Co-authored-by: Avi Ribchinsky <[email protected]> Co-authored-by: Tatyana <[email protected]> Co-authored-by: Idan Adar <[email protected]> Deprecating alias and bindings APIs and schema items (IBM-Cloud#5612) * Deprecating alias and bindings APIs and schema items Signed-off-by: arshabbir <[email protected]> * Deprecating alias and bindings APIs and schema items --------- Signed-off-by: arshabbir <[email protected]> Add region parameter to logs-routing resources and data sources (IBM-Cloud#5634) * Added region parameter to logs-routing resources and data sources Signed-off-by: Ian Reyes <[email protected]> * Fixed examples for logs-routing resources --------- Signed-off-by: Ian Reyes <[email protected]> Co-authored-by: Ian Reyes <[email protected]> update(cloud-databases): Make Service Endpoints Required and send warning when public endpoints are in use (IBM-Cloud#5402) Added support for reserved ip patch resource (IBM-Cloud#5603) * Added support for ibm_is_subnet_reserved_ip_patch resource * updated the name to optional * Update is_subnet_reserved_ip_patch.html.markdown fix(is_share): added empty check and moved source_share_crn outside (IBM-Cloud#5632) discourage use of ibm_container_bind_service (IBM-Cloud#5588) * discourage use of ibm_container_bind_service Signed-off-by: Bence Vidosits <[email protected]> * fix link --------- Signed-off-by: Bence Vidosits <[email protected]> Co-authored-by: Bence Vidosits <[email protected]> updated resources, data source and documentation for Slack Direct destination support Add test bucket endpoints (IBM-Cloud#5636) * add changes for test bucket endpoints * update code --------- Co-authored-by: Deeksha Sharma <[email protected]> Add support for Code Engine functions (IBM-Cloud#5596) * Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check Fix the 5635 - The ibm_resource_tag now checks the response in the api tags calls (IBM-Cloud#5641) * Deprecated ibm_resource_access_tag in favor of ibm_iam_access_tag * changes * Fix * Changed resource to speed up tests * fix * PR changes * PR changes --------- --------- Deprecating alias and bindings APIs and schema items (IBM-Cloud#5612) --------- IAM Policy Assignment: S2S Policy Assignments ET and AG (IBM-Cloud#5624) * IAM Policy Assignment: S2S Policy Assignments ET and AG Signed-off-by: Alluri-Varma <[email protected]> * resolving CVE's for EPAP * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG --------- Signed-off-by: Alluri-Varma <[email protected]> Co-authored-by: Alluri-Varma <[email protected]> migrattion of vpc-go-sdk to 0.58.0 (IBM-Cloud#5652) * migration of vpc-go-sdk to 0.58.0 * make fmt changes IAM Policy Assignment: S2S Policy Assignments ET and AG (IBM-Cloud#5624) * IAM Policy Assignment: S2S Policy Assignments ET and AG Signed-off-by: Alluri-Varma <[email protected]> * resolving CVE's for EPAP * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG * IAM Policy Assignment: S2S Policy Assignments ET and AG --------- Signed-off-by: Alluri-Varma <[email protected]> Co-authored-by: Alluri-Varma <[email protected]> migrattion of vpc-go-sdk to 0.58.0 (IBM-Cloud#5652) * migration of vpc-go-sdk to 0.58.0 * make fmt changes
* Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check
* Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check
* Add support for Code Engine functions * update .secrets.baseline * remove unnecessary check
Community Note
Relates OR Closes #0000
Output from acceptance testing: