Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code engine job regression #5347 #5545

Merged

Conversation

michael-magrian
Copy link
Contributor

@michael-magrian michael-magrian commented Aug 5, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #5347

Fixes a regression introduced in the linked pull request, where a default value was removed, thus causing validation errors for existing Terraform templates when updates are performed for the resource ibm_code_engine_job.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIbmCodeEngineJobDataSourceBasic'

=== RUN   TestAccIbmCodeEngineJobDataSourceBasic
--- PASS: TestAccIbmCodeEngineJobDataSourceBasic (12.85s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/codeengine      14.487s
...
$ make testacc TESTARGS='-run=TestAccIbmCodeEngineJobDataSourceExtended'

=== RUN   TestAccIbmCodeEngineJobDataSourceExtended
--- PASS: TestAccIbmCodeEngineJobDataSourceExtended (14.27s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/codeengine      23.981s
...
$ make testacc TESTARGS='-run=TestAccIbmCodeEngineJobBasic'

=== RUN   TestAccIbmCodeEngineJobBasic
--- PASS: TestAccIbmCodeEngineJobBasic (25.44s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/codeengine      34.803s
...
$ make testacc TESTARGS='-run=TestAccIbmCodeEngineJobExtended'

=== RUN   TestAccIbmCodeEngineJobExtended
--- PASS: TestAccIbmCodeEngineJobExtended (27.07s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/codeengine      35.580s
...

@hkantare hkantare merged commit b0d447b into IBM-Cloud:master Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants