Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Cloud-Databases): Remove Datastax #5511

Merged
merged 3 commits into from
Jul 31, 2024
Merged

chore(Cloud-Databases): Remove Datastax #5511

merged 3 commits into from
Jul 31, 2024

Conversation

omaraibrahim
Copy link
Collaborator

Description

Remove Datastax from our terraform offering as it's no longer offered.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@omaraibrahim omaraibrahim marked this pull request as ready for review July 16, 2024 14:38
@omaraibrahim omaraibrahim changed the title chore(Cloud-Databases): Remove datastax chore(Cloud-Databases): Remove Datastax Jul 16, 2024
lornakelly
lornakelly approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@lornakelly lornakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lornakelly
lornakelly approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@lornakelly lornakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omaraibrahim omaraibrahim merged commit af032b8 into IBM-Cloud:master Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lornakelly lornakelly lornakelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omaraibrahim @lornakelly