Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clevos 94481 remove hardcoded endpoints #5484

Merged

Conversation

IBM-Deeksha
Copy link
Contributor

@IBM-Deeksha IBM-Deeksha commented Jul 4, 2024

Contributes to: https://jiracloud.swg.usma.ibm.com:8443/browse/CLEVOS-94481

  • remove hardcoded values for private and direct cos config endpoint. Use defaults values when no env variables are set

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@IBM-Deeksha IBM-Deeksha marked this pull request as ready for review July 8, 2024 13:00
@cjschaef
Copy link

I was doing some testing using this branch, I hit some errors. Will try to get more details to see if it is a configuration issue or a bug.

@IBM-Deeksha
Copy link
Contributor Author

IBM-Deeksha commented Jul 15, 2024

Thanks @cjschaef. If possible could you please share the error message

@cjschaef
Copy link

This is the error I receive

time="2024-07-16T01:45:57Z" level=error msg="Error: [ERROR] Error retrieving service offering: Request failed with status code: 404, ServerErrorResponse: {\"message\":\"Requested page not found.\",\"code\":404,\"global_transaction_id\":\"7c7b2f09-ec3c-408e-a60b-23f5efbbd618\"}"
time="2024-07-16T01:45:57Z" level=error
time="2024-07-16T01:45:57Z" level=error
time="2024-07-16T01:45:57Z" level=error msg="  with ibm_resource_instance.cos,"
time="2024-07-16T01:45:57Z" level=error msg="  on main.tf line 28, in resource \"ibm_resource_instance\" \"cos\":"
time="2024-07-16T01:45:57Z" level=error msg="  28: resource \"ibm_resource_instance\" \"cos\" {"
time="2024-07-16T01:45:57Z" level=error
time="2024-07-16T01:45:57Z" level=error msg=---
time="2024-07-16T01:45:57Z" level=error msg="id: terraform-446cc00a"
time="2024-07-16T01:45:57Z" level=error msg="summary: |"
time="2024-07-16T01:45:57Z" level=error msg="  [ERROR] Error retrieving service offering: Request failed with status code: 404, ServerErrorResponse: {\"message\":\"Requested page not found.\",\"code\":404,\"global_transaction_id\":\"7c7b2f09-ec3c-408e-a60b-23f5efbbd618\"}"
time="2024-07-16T01:45:57Z" level=error msg="severity: error"
time="2024-07-16T01:45:57Z" level=error msg="resource: ibm_resource_instance"
time="2024-07-16T01:45:57Z" level=error msg="operation: create"
time="2024-07-16T01:45:57Z" level=error msg="component:"
time="2024-07-16T01:45:57Z" level=error msg="  name: github.com/IBM-Cloud/terraform-provider-ibm"
time="2024-07-16T01:45:57Z" level=error msg="  version: 1.65.0"
time="2024-07-16T01:45:57Z" level=error msg=---

With this definition

resource "ibm_resource_instance" "cos" {
  name              = "${var.cluster_id}-cos"
  service           = "cloud-object-storage"
  plan              = "standard"
  location          = "global"
  resource_group_id = local.resource_group_id
  tags              = local.tags
}

@cjschaef
Copy link

From what I understand, I don't see how this relates to your changes, so I am continuing to get more details.

@cjschaef
Copy link

I think I have identified the issue is related to Global Catalog endpoint, not your changes. I will continue to try to test to confirm things.

@hkantare hkantare merged commit 536f2ad into IBM-Cloud:master Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants