Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to handle crash for cloudshell #5363

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix to handle crash for cloudshell #5363

merged 1 commit into from
May 17, 2024

Conversation

hkantare
Copy link
Collaborator

harinireddy@Harinis-MBP default % unset TF_LOG
harinireddy@Harinis-MBP default % terraform1.5 apply  
var.ibmcloud_api_key
  The IBM Cloud API token this account authenticates to

  Enter a value: 

module.iam_account_settings.data.ibm_iam_account_settings.iam_account_settings: Reading...
module.iam_account_settings.data.ibm_iam_account_settings.iam_account_settings: Read complete after 1s [id=883079c85357a1f3f85d968780e56518]
module.iam_account_settings.data.ibm_cloud_shell_account_settings.cloud_shell_account_settings[0]: Reading...
module.iam_account_settings.data.ibm_cloud_shell_account_settings.cloud_shell_account_settings[0]: Read complete after 2s [id=883079c85357a1f3f85d968780e56518]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.iam_account_settings.ibm_cloud_shell_account_settings.cloud_shell_account_settings[0] will be created
  + resource "ibm_cloud_shell_account_settings" "cloud_shell_account_settings" {
      + account_id = "883079c85357a1f3f85d968780e56518"
      + created_at = (known after apply)
      + created_by = (known after apply)
      + enabled    = false
      + id         = (known after apply)
      + rev        = "28-4858fbf15bf0008b86a37a15b2248323"
      + type       = (known after apply)
      + updated_at = (known after apply)
      + updated_by = (known after apply)
    }

  # module.iam_account_settings.ibm_iam_access_group_account_settings.iam_access_group_account_settings will be created
  + resource "ibm_iam_access_group_account_settings" "iam_access_group_account_settings" {
      + account_id            = (known after apply)
      + id                    = (known after apply)
      + public_access_enabled = false
    }

  # module.iam_account_settings.ibm_iam_account_settings.iam_account_settings will be created
  + resource "ibm_iam_account_settings" "iam_account_settings" {
      + allowed_ip_addresses                       = "0.0.0.0/0"
      + entity_tag                                 = (known after apply)
      + history                                    = (known after apply)
      + id                                         = (known after apply)
      + if_match                                   = "*"
      + include_history                            = false
      + max_sessions_per_identity                  = "NOT_SET"
      + mfa                                        = "TOTP4ALL"
      + restrict_create_platform_apikey            = "RESTRICTED"
      + restrict_create_service_id                 = "RESTRICTED"
      + session_expiration_in_seconds              = "86400"
      + session_invalidation_in_seconds            = "7200"
      + system_access_token_expiration_in_seconds  = "3600"
      + system_refresh_token_expiration_in_seconds = "259200"
    }

Plan: 3 to add, 0 to change, 0 to destroy.

Changes to Outputs:
  + account_allowed_ip_addresses              = "0.0.0.0/0"
  + account_allowed_ip_addresses_control_mode = "RESTRICT"
  + account_allowed_ip_addresses_enforced     = true
  + account_iam_access_token_expiration       = "3600"
  + account_iam_active_session_timeout        = "86400"
  + account_iam_apikey_creation               = "RESTRICTED"
  + account_iam_inactive_session_timeout      = "7200"
  + account_iam_mfa                           = "TOTP4ALL"
  + account_iam_refresh_token_expiration      = "259200"
  + account_iam_serviceid_creation            = "RESTRICTED"
  + account_iam_user_mfa_list                 = []
  + account_public_access                     = false
  + account_shell_settings_status             = false

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

module.iam_account_settings.ibm_iam_access_group_account_settings.iam_access_group_account_settings: Creating...
module.iam_account_settings.ibm_iam_account_settings.iam_account_settings: Creating...
module.iam_account_settings.ibm_cloud_shell_account_settings.cloud_shell_account_settings[0]: Creating...
module.iam_account_settings.ibm_iam_account_settings.iam_account_settings: Creation complete after 1s [id=883079c85357a1f3f85d968780e56518]
module.iam_account_settings.ibm_iam_access_group_account_settings.iam_access_group_account_settings: Creation complete after 2s [id=883079c85357a1f3f85d968780e56518]
module.iam_account_settings.ibm_cloud_shell_account_settings.cloud_shell_account_settings[0]: Creation complete after 4s [id=ac-883079c85357a1f3f85d968780e56518]

Apply complete! Resources: 3 added, 0 changed, 0 destroyed.

Outputs:

account_allowed_ip_addresses = "0.0.0.0/0"
account_allowed_ip_addresses_control_mode = "RESTRICT"
account_allowed_ip_addresses_enforced = true
account_iam_access_token_expiration = "3600"
account_iam_active_session_timeout = "86400"
account_iam_apikey_creation = "RESTRICTED"
account_iam_inactive_session_timeout = "7200"
account_iam_mfa = "TOTP4ALL"
account_iam_refresh_token_expiration = "259200"
account_iam_serviceid_creation = "RESTRICTED"
account_iam_user_mfa_list = tolist([])
account_public_access = false
account_shell_settings_status = false
harinireddy@Harinis-MBP default % 

Copy link
Collaborator

@kavya498 kavya498 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kavya498 kavya498 merged commit e590793 into master May 17, 2024
1 check passed
@kavya498 kavya498 deleted the cloudshell/fix branch May 17, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants